Tests from test_share_links_search are causing timing issues with QThread
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Ubuntu One Control Panel | Status tracked in Trunk | |||||
Stable-4-2 |
Fix Released
|
Undecided
|
Unassigned | |||
Trunk |
Fix Released
|
Undecided
|
Diego Sarmentero |
Bug Description
The start method from QThread is not being patched properly and this is causing a race condition because some part of the test is running as a thread.
In one of my computers (Mac, which is slower) i'm getting this:
[FAIL]
Traceback (most recent call last):
File "/Users/
self.
File "/Users/
% (msg, pformat(first), pformat(second)))
twisted.
a = ['~/blabla/iop']
b = []
ubuntuone.
=======
[FAIL]
Traceback (most recent call last):
File "/Users/
self.
File "/Users/
% (msg, pformat(first), pformat(second)))
twisted.
a = 0
b = 20
ubuntuone.
=======
[FAIL]
Traceback (most recent call last):
File "/Users/
self.
File "/Users/
% (msg, pformat(first), pformat(second)))
twisted.
a = -1
b = 0
ubuntuone.
=======
[FAIL]
Traceback (most recent call last):
File "/Users/
self.
File "/Users/
% (msg, pformat(first), pformat(second)))
twisted.
a = []
b = ['other_
'~/blabla/iop',
'~/one/file3',
'~/test/asd',
'~/ubuntu/file1',
'~/ubuntu/file2']
ubuntuone.
=======
[ERROR]
Traceback (most recent call last):
File "/Users/
self.
File "/Users/
self.
File "/Users/
self.
exceptions.
ubuntuone.
-------
Ran 1254 tests in 83.117s
FAILED (skips=1, failures=4, errors=1, successes=1248)
This is because the start() function of the QThread is executed in the initialization of the object before these method is patched properly.
Related branches
- dobey (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 85 lines (+25/-2)3 files modifiedubuntuone/controlpanel/gui/qt/tests/test_gui.py (+8/-0)
ubuntuone/controlpanel/gui/qt/tests/test_share_links.py (+7/-0)
ubuntuone/controlpanel/gui/qt/tests/test_share_links_search.py (+10/-2)
description: | updated |
Changed in ubuntuone-control-panel: | |
status: | In Progress → Fix Committed |
Changed in ubuntuone-control-panel: | |
status: | Fix Committed → Fix Released |