Fix for bug #932623 does not take separate doublewrite tablespace into account
Bug #1066843 reported by
Alexey Kopytov
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona XtraBackup moved to https://jira.percona.com/projects/PXB |
Fix Released
|
Critical
|
Sergei Glushchenko | ||
| 2.0 |
Fix Released
|
Critical
|
Sergei Glushchenko | ||
| 2.1 |
Fix Released
|
Critical
|
Sergei Glushchenko | ||
Bug Description
The fix for bug #932623 does not take separate doublewrite tablespace into account. The following assertion assumes the system tablespace to always have id 0:
ut_a(dbname != NULL || space_id == 0 || space_id == ULINT_UNDEFINED);
However, in Percona Server a tablespace is "system" (i.e. does not belong to any specific database) if it is either ibdata1 (with space id 0), or a separate doublewrite tablespace (with space id 0xFFFFFFE0). The latter tablespace, if present, will result in --apply-log crash with the above assertion failing when preparing an incremental backup.
Related branches
lp://staging/~sergei.glushchenko/percona-xtrabackup/BT-26901-2.0
- Alexey Kopytov (community): Approve
- Laurynas Biveinis: Pending requested
-
Diff: 283 lines (+148/-26)3 files modifiedinnobackupex (+14/-1)
src/xtrabackup.c (+14/-25)
test/t/ib_doublewrite.sh (+120/-0)
lp://staging/~sergei.glushchenko/percona-xtrabackup/BT-26901-2.1
- Alexey Kopytov (community): Approve
- Laurynas Biveinis: Pending requested
-
Diff: 200 lines (+144/-2)3 files modifiedinnobackupex (+14/-1)
src/xtrabackup.c (+10/-1)
test/t/ib_doublewrite.sh (+120/-0)
- Laurynas Biveinis (community): Needs Fixing
-
Diff: 7928 lines (+3748/-2732) (has conflicts)36 files modifiedVERSION (+1/-1)
doc/source/conf.py (+3/-3)
doc/source/innobackupex/how_innobackupex_works.rst (+0/-4)
doc/source/innobackupex/innobackupex_option_reference.rst (+2/-6)
doc/source/innobackupex/innobackupex_script.rst (+0/-1)
doc/source/innobackupex/remote_backups_ibk.rst.THIS (+1/-5)
doc/xtrabackup.1 (+0/-15)
innobackupex (+54/-207)
src/Makefile (+14/-5)
src/common.h (+27/-7)
src/datasink.c (+113/-0)
src/datasink.h (+46/-8)
src/ds_compress.c (+31/-70)
src/ds_compress.h (+2/-5)
src/ds_local.c (+0/-3)
src/ds_local.h (+2/-2)
src/ds_stream.c (+5/-2)
src/ds_stream.h (+2/-2)
src/ds_tmpfile.c (+243/-0)
src/ds_tmpfile.h (+28/-0)
src/fil_cur.c (+270/-0)
src/fil_cur.h (+96/-0)
src/innodb_int.c (+983/-0)
src/innodb_int.h (+695/-0)
src/quicklz/quicklz.h (+1/-0)
src/write_filt.c (+321/-0)
src/write_filt.h (+65/-0)
src/xbstream.c (+15/-19)
src/xtrabackup.c (+461/-2365)
src/xtrabackup.h (+50/-0)
test/disabled/compact.sh (+35/-0)
test/disabled/compact_compressed.sh (+53/-0)
test/inc/common.sh (+19/-0)
test/run.sh (+1/-0)
test/t/bug1066843.sh (+107/-0)
test/t/bug766033.sh (+2/-2)
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #1 |
To post a comment you must log in.
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/