install does not check errors
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| wordpress (Juju Charms Collection) |
Fix Released
|
Medium
|
Matthew Ruffell | ||
Bug Description
Just had this happen:
2012-10-10 05:42:20,308: hook.output@INFO: Err http://
2012-10-10 05:42:20,309: hook.output@INFO: Could not connect to ppa.launchpad.
2012-10-10 05:42:20,309: hook.output@INFO: Err http://
2012-10-10 05:42:20,311: hook.output@INFO: Failed to fetch http://
2012-10-10 05:42:20,324: hook.output@INFO: Fetched 57.5 MB in 1min 3s (910 kB/s)
2012-10-10 05:42:20,324: hook.output@INFO: E
2012-10-10 05:42:20,324: hook.output@INFO: :
2012-10-10 05:42:20,325: hook.output@INFO: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
2012-10-10 05:42:20,325: hook.output@INFO:
2012-10-10 05:41:24,929: hook.output@INFO: Get:74 http://
This should have made an error on install, but instead it merrily continued.. with more assumptions failing...
2012-10-10 05:42:23,799: unit.hook.api@INFO: Installing Nginx common config ...
2012-10-10 05:42:23,880: hook.output@INFO: install:
2012-10-10 05:42:23,880: hook.output@INFO: cannot create regular file `/etc/nginx/
2012-10-10 05:42:23,880: hook.output@INFO: : No such file or directory
2012-10-10 05:42:23,881: hook.output@INFO:
2012-10-10 05:42:24,383: unit.hook.api@INFO: Installing Nginx actual site config ...
2012-10-10 05:42:24,434: hook.output@INFO: install:
2012-10-10 05:42:24,435: hook.output@INFO: cannot create regular file `/etc/nginx/
2012-10-10 05:42:24,435: hook.output@INFO: : No such file or directory
2012-10-10 05:42:24,435: hook.output@INFO:
This should have resulted in install-error, but instead we did not see a fail until start.
I believe the fix is a simple 'set -e' at the top of the script.
Related branches
- Marco Ceppi (community): Approve
-
Diff: 34 lines (+11/-7)1 file modifiedhooks/install (+11/-7)
| Changed in wordpress (Juju Charms Collection): | |
| assignee: | nobody → Dave Cheney (dave-cheney) |
| importance: | Undecided → Medium |
| status: | New → In Progress |
| Matthew Ruffell (mruffell) wrote | #1 |
| Changed in wordpress (Juju Charms Collection): | |
| status: | In Progress → Fix Released |
| assignee: | Dave Cheney (dave-cheney) → nobody |
| assignee: | nobody → Matthew Ruffell (mruffell) |
This bug has been fixed in the major maintenance performed on the wordpress charm, now known as cs:wordpress-0.
Install script now does a "set -e".
For more information, see Bug 1827164.