Bug #1061949 “share_links search box should not search within fo...” : Bugs : Ubuntu One Control Panel

Mike McCracken (mikemc) on 2012-10-05

tags:

added: desktop+

Revision history for this message

Mike McCracken (mikemc) wrote on 2012-10-05:

#1

Download full text (4.9 KiB)

This causes an error in syncdaemon, which is logged but not propagated to the control panel UI.

The right fix is to avoid the error, although there's also a problem that the control panel doesn't seem to be receiving or handling the error callback.

Here's the syncdaemon log from trying this:

2012-10-05 09:37:03,661 - ubuntuone.SyncDaemon.InteractionInterfaces - DEBUG - change_public_access: args (<ubuntuone.syncdaemon.interaction_interfaces.SyncdaemonPublicFiles object at 0x104804490>, u'fe76df32-6a95-4a6d-ab74-e4512c50b8e9', u'434f2d47-6a52-4b98-961b-2c28f8e6c3ce', True), kwargs {}.
2012-10-05 09:37:03,661 - ubuntuone.SyncDaemon.ActionQueue - DEBUG - ChangePublicAccess share:UUID('fe76df32-6a95-4a6d-ab74-e4512c50b8e9') node:UUID('434f2d47-6a52-4b98-961b-2c28f8e6c3ce') ChangePublicAccess(running='False') queueing
2012-10-05 09:37:03,661 - ubuntuone.SyncDaemon.EQ - DEBUG - push_event: SYS_QUEUE_ADDED, kwargs: {'command': <ubuntuone.syncdaemon.action_queue.ChangePublicAccess object at 0x105e983b0>}
2012-10-05 09:37:03,661 - ubuntuone.SyncDaemon.Pb - DEBUG - emitting 'on_metaqueue_changed' to all (1) connected clients.
2012-10-05 09:37:03,662 - ubuntuone.SyncDaemon.Pb - DEBUG - emitting 'on_request_queue_added' to all (0) connected clients.
2012-10-05 09:37:03,662 - ubuntuone.SyncDaemon.ActionQueue - DEBUG - ChangePublicAccess share:UUID('fe76df32-6a95-4a6d-ab74-e4512c50b8e9') node:UUID('434f2d47-6a52-4b98-961b-2c28f8e6c3ce') ChangePublicAccess(running='False') starting
2012-10-05 09:37:03,663 - ubuntuone.SyncDaemon.ActionQueue - DEBUG - ChangePublicAccess share:UUID('fe76df32-6a95-4a6d-ab74-e4512c50b8e9') node:UUID('434f2d47-6a52-4b98-961b-2c28f8e6c3ce') ChangePublicAccess(running='False') started
2012-10-05 09:37:03,663 - ubuntuone.SyncDaemon.ActionQueue - DEBUG - ChangePublicAccess share:UUID('fe76df32-6a95-4a6d-ab74-e4512c50b8e9') node:UUID('434f2d47-6a52-4b98-961b-2c28f8e6c3ce') ChangePublicAccess(running='False') running
2012-10-05 09:37:03,666 - ubuntuone.SyncDaemon.InteractionInterfaces - DEBUG - change_public_access: result None.
2012-10-05 09:37:03,919 - ubuntuone.SyncDaemon.EQ - DEBUG - push_event: AQ_DOWNLOAD_FILE_PROGRESS, kwargs: {'deflated_size': 36632583L, 'node_id': 'a0c94db7-be64-4eac-b2b8-30d8e615168f', 'share_id': '', 'n_bytes_read': 4352496}
2012-10-05 09:37:03,919 - ubuntuone.SyncDaemon.Pb - DEBUG - emitting 'on_download_file_progress' to all (1) connected clients.
2012-10-05 09:37:04,513 - ubuntuone.SyncDaemon.EQ - DEBUG - push_event: AQ_DOWNLOAD_FILE_PROGRESS, kwargs: {'deflated_size': 36632583L, 'node_id': 'a0c94db7-be64-4eac-b2b8-30d8e615168f', 'share_id': '', 'n_bytes_read': 4425286}
2012-10-05 09:37:04,514 - ubuntuone.SyncDaemon.Pb - DEBUG - emitting 'on_download_file_progress' to all (1) connected clients.
2012-10-05 09:37:04,603 - ubuntuone.SyncDaemon.ActionQueue - ERROR - ChangePublicAccess share:UUID('fe76df32-6a95-4a6d-ab74-e4512c50b8e9') node:UUID('434f2d47-6a52-4b98-961b-2c28f8e6c3ce') ChangePublicAccess(running='False') failure: ('FORBIDDEN', "Can't make shared files public.") (traceback follows)
Traceback (most recent call last):
File "ubuntuone/syncdaemo...

This causes an error in syncdaemon, which is logged but not propagated to the control panel UI.

The right fix is to avoid the error, although there's also a problem that the control panel doesn't seem to be receiving or handling the error callback.

Here's the syncdaemon log from trying this:

2012-10-05 09:37:03,661 - ubuntuone.SyncDaemon.InteractionInterfaces - DEBUG - change_public_access: args (<ubuntuone.syncdaemon.interaction_interfaces.SyncdaemonPublicFiles object at 0x104804490>, u'fe76df32-6a95-4a6d-ab74-e4512c50b8e9', u'434f2d47-6a52-4b98-961b-2c28f8e6c3ce', True), kwargs {}.
2012-10-05 09:37:03,661 - ubuntuone.SyncDaemon.ActionQueue - DEBUG - ChangePublicAccess           share:UUID('fe76df32-6a95-4a6d-ab74-e4512c50b8e9') node:UUID('434f2d47-6a52-4b98-961b-2c28f8e6c3ce') ChangePublicAccess(running='False') queueing
2012-10-05 09:37:03,661 - ubuntuone.SyncDaemon.EQ - DEBUG - push_event: SYS_QUEUE_ADDED, kwargs: {'command': <ubuntuone.syncdaemon.action_queue.ChangePublicAccess object at 0x105e983b0>}
2012-10-05 09:37:03,661 - ubuntuone.SyncDaemon.Pb - DEBUG - emitting 'on_metaqueue_changed' to all (1) connected clients.
2012-10-05 09:37:03,662 - ubuntuone.SyncDaemon.Pb - DEBUG - emitting 'on_request_queue_added' to all (0) connected clients.
2012-10-05 09:37:03,662 - ubuntuone.SyncDaemon.ActionQueue - DEBUG - ChangePublicAccess           share:UUID('fe76df32-6a95-4a6d-ab74-e4512c50b8e9') node:UUID('434f2d47-6a52-4b98-961b-2c28f8e6c3ce') ChangePublicAccess(running='False') starting
2012-10-05 09:37:03,663 - ubuntuone.SyncDaemon.ActionQueue - DEBUG - ChangePublicAccess           share:UUID('fe76df32-6a95-4a6d-ab74-e4512c50b8e9') node:UUID('434f2d47-6a52-4b98-961b-2c28f8e6c3ce') ChangePublicAccess(running='False') started
2012-10-05 09:37:03,663 - ubuntuone.SyncDaemon.ActionQueue - DEBUG - ChangePublicAccess           share:UUID('fe76df32-6a95-4a6d-ab74-e4512c50b8e9') node:UUID('434f2d47-6a52-4b98-961b-2c28f8e6c3ce') ChangePublicAccess(running='False') running
2012-10-05 09:37:03,666 - ubuntuone.SyncDaemon.InteractionInterfaces - DEBUG - change_public_access: result None.
2012-10-05 09:37:03,919 - ubuntuone.SyncDaemon.EQ - DEBUG - push_event: AQ_DOWNLOAD_FILE_PROGRESS, kwargs: {'deflated_size': 36632583L, 'node_id': 'a0c94db7-be64-4eac-b2b8-30d8e615168f', 'share_id': '', 'n_bytes_read': 4352496}
2012-10-05 09:37:03,919 - ubuntuone.SyncDaemon.Pb - DEBUG - emitting 'on_download_file_progress' to all (1) connected clients.
2012-10-05 09:37:04,513 - ubuntuone.SyncDaemon.EQ - DEBUG - push_event: AQ_DOWNLOAD_FILE_PROGRESS, kwargs: {'deflated_size': 36632583L, 'node_id': 'a0c94db7-be64-4eac-b2b8-30d8e615168f', 'share_id': '', 'n_bytes_read': 4425286}
2012-10-05 09:37:04,514 - ubuntuone.SyncDaemon.Pb - DEBUG - emitting 'on_download_file_progress' to all (1) connected clients.
2012-10-05 09:37:04,603 - ubuntuone.SyncDaemon.ActionQueue - ERROR - ChangePublicAccess           share:UUID('fe76df32-6a95-4a6d-ab74-e4512c50b8e9') node:UUID('434f2d47-6a52-4b98-961b-2c28f8e6c3ce') ChangePublicAccess(running='False') failure: ('FORBIDDEN', "Can't make shared files public.") (traceback follows)
Traceback (most recent call last):
  File "ubuntuone/syncdaemon/action_queue.pyc", line 1522, in run
  File "twisted/internet/defer.pyc", line 1037, in _inlineCallbacks
  File "twisted/python/failure.pyc", line 382, in throwExceptionIntoGenerator
  File "ubuntuone/syncdaemon/action_queue.pyc", line 2252, in _change_public_access_http
  File "twisted/internet/defer.pyc", line 1037, in _inlineCallbacks
  File "twisted/python/failure.pyc", line 382, in throwExceptionIntoGenerator
  File "ubuntuone/syncdaemon/action_queue.pyc", line 930, in webcall
  File "twisted/internet/defer.pyc", line 1039, in _inlineCallbacks
  File "ubuntu_sso/utils/webclient/txweb.pyc", line 161, in request
WebClientError: ('FORBIDDEN', "Can't make shared files public.")
2012-10-05 09:37:04,603 - ubuntuone.SyncDaemon.EQ - DEBUG - push_event: AQ_CHANGE_PUBLIC_ACCESS_ERROR, kwargs: {'share_id': UUID('fe76df32-6a95-4a6d-ab74-e4512c50b8e9'), 'node_id': UUID('434f2d47-6a52-4b98-961b-2c28f8e6c3ce'), 'error': "Can't make shared files public."}
2012-10-05 09:37:04,603 - ubuntuone.SyncDaemon.InteractionInterfaces - DEBUG - handle_AQ_CHANGE_PUBLIC_ACCESS_ERROR: args (<ubuntuone.syncdaemon.interaction_interfaces.SyncdaemonEventListener object at 0x105efadd0>,), kwargs {'share_id': UUID('fe76df32-6a95-4a6d-ab74-e4512c50b8e9'), 'node_id': UUID('434f2d47-6a52-4b98-961b-2c28f8e6c3ce'), 'error': "Can't make shared files public."}.
2012-10-05 09:37:04,604 - ubuntuone.SyncDaemon.Pb - DEBUG - emitting 'on_public_access_change_error' to all (1) connected clients.
2012-10-05 09:37:04,604 - ubuntuone.SyncDaemon.InteractionInterfaces - DEBUG - handle_AQ_CHANGE_PUBLIC_ACCESS_ERROR: result None.
2012-10-05 09:37:04,604 - ubuntuone.SyncDaemon.EQ - DEBUG - push_event: SYS_QUEUE_REMOVED, kwargs: {'command': <ubuntuone.syncdaemon.action_queue.ChangePublicAccess object at 0x105e983b0>}

summary:	- control panel ui hangs after selecting a file that was shared with me in - the share_links search box. + share_links search box should not search within folders that are shared + with me.
Changed in ubuntuone-control-panel:
importance:	Undecided → High
status:	New → Confirmed
assignee:	nobody → Roberto Alsina (ralsina)

Roberto Alsina (ralsina) on 2012-10-05

Changed in ubuntuone-control-panel:
assignee:	Roberto Alsina (ralsina) → Diego Sarmentero (diegosarmentero)

Ubuntu One Auto Pilot (otto-pilot) on 2012-10-15

Changed in ubuntuone-control-panel:
status:	Confirmed → Fix Committed

	Status	Importance	Assigned to	Milestone
Ubuntu One Control Panel	Status tracked in Trunk
Stable-4-2	Fix Released	Undecided	Unassigned	Ubuntu One Control Panel 4.1.0
Trunk	Fix Released	High	Diego Sarmentero

Ubuntu One Control Panel

share_links search box should not search within folders that are shared with me.

Bug Description

Related branches

Other bug subscribers

Remote bug watches