--ignore-return may cause processes to exit prematurely
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
DBus Test Runner |
Fix Released
|
Medium
|
Ted Gould |
Bug Description
I don't think that http://
Ignore-return is for a task to always pass regardless of its return value, and that's how dbus_test_
But all_tasks_
Found by dbusmenu's test-json exiting prematurely because all of its tasks were ignore-return. On my machine, test-json-server was exiting before test-json-client even started. Sometimes. Or not. Depending on timing issues, the phase of the moon, and the polarity of the neutron flow.
Related branches
- jenkins (community): Approve (continuous-integration)
- Charles Kerr (community): Approve
-
Diff: 198 lines (+93/-1)8 files modified.bzrignore (+4/-0)
libdbustest/service.c (+1/-1)
libdbustest/task.c (+36/-0)
libdbustest/task.h (+2/-0)
src/dbus-test-runner.c (+18/-0)
tests/Makefile.am (+15/-0)
tests/test-wait-output.reference (+5/-0)
tests/test-wait-outputer (+12/-0)
description: | updated |
Changed in dbus-test-runner: | |
status: | Incomplete → In Progress |
assignee: | nobody → Ted Gould (ted) |
Changed in dbus-test-runner: | |
status: | In Progress → Fix Committed |
Changed in dbus-test-runner: | |
milestone: | none → 12.10.1 |
status: | Fix Committed → Fix Released |
The idea was that if a task doesn't have results we care about, don't block on it. This could be used for things like mock services wouldn't have a explicit kill, but when the test is complete should be torn down.