elementary OS

"Applications" launcher is present in Wingpanel in Ubiquity session

Bug #1047682 reported by Sergey "Shnatsel" Davidoff
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Wingpanel
Invalid
Medium
Unassigned
elementary OS
Won't Fix
Medium
Unassigned

Bug Description

"Applications" launcher is present in Wingpanel in the LiveCD greeter with the language selection try/install buttons; it's not supposed to be there.

Ubiquity now unsets the dconf key correctly. A screenshot of dconf-editor showing the key being unset yet Wingpanel still showing the launcher is attached. Killing Wingpanel and launching it again fixes the issue.

There seems to be a race condition in Wingpanel in setting up dconf watches.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :
Revision history for this message
Andrea Basso (voluntatefaber) wrote :

I can't confirm whether it shows or not during installing, but I can confirm show_launcher is not updated on the fly.

Revision history for this message
Andrea Basso (voluntatefaber) wrote :

Uhm, this is strange... I've hacked a bit, then reverted changes and now it works...

Revision history for this message
Andrea Basso (voluntatefaber) wrote :

Ok, my bad, I musta done something wrong, I re-branched wingpanel and now it is updated on the fly.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

It does update on the fly when I manually toggle it. However, it does not when Ubiquity unsets the key on startup. The only reasonable explaination I came up with is a race condition in setting up or using the dconf watches.

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Could be a race, but cleaning up the responsible code *might* work too.

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

I pushed this proposed *maybe* fix.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Unfortunately, that didn't fix it.

Sergey "Shnatsel" Davidoff (shnatsel)
Changed in elementaryos:
milestone: luna-beta1 → luna-beta2
Sergey "Shnatsel" Davidoff (shnatsel)
Changed in elementaryos:
importance: Undecided → Medium
David Gomes (davidgomes)
Changed in elementaryos:
status: New → Confirmed
Changed in wingpanel:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Danielle Foré (danrabbit) wrote :

One thing we should consider is maybe this is actually a feature? I've heard users actually applauding that we allow them to access all apps during install.

Changed in elementaryos:
milestone: luna-beta2 → luna-beta3
Revision history for this message
Victor Martinez (victored) wrote :

The gsettings key works perfectly here. It's also applied accordingly when the value is changed.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Awaiting design decision - should we get rid of it or not?

Changed in elementaryos:
status: Confirmed → Incomplete
Cody Garver (codygarver)
Changed in elementaryos:
milestone: luna-beta3 → luna-rc1
Revision history for this message
Danielle Foré (danrabbit) wrote :

Let's just decide this is a feature since we don't know wtf is going wrong :P

Changed in elementaryos:
status: Incomplete → Won't Fix
Changed in wingpanel:
status: Confirmed → Invalid
Danielle Foré (danrabbit)
Changed in elementaryos:
milestone: luna-rc1 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.