.gir file needs additional fields for Vala

Bug #1044096 reported by Jim Nelson
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Messaging Menu
Fix Released
High
Lars Karlitski
indicator-messages (Ubuntu)
Fix Released
High
Unassigned

Bug Description

valac generates an invalid #include line in the .c code when using MessagingMenu-1.0.gir as a package:

#include <MessagingMenu-1.0.h>

The .gir file needs two additional fields (so far as I can tell) in order for it to work with Vala without requiring a .vapi file:

<c:include name="messaging-menu.h"/>
<package name="messaging-menu"/>

Changed in indicator-messages (Ubuntu):
status: New → Confirmed
Revision history for this message
Lars Karlitski (larsu) wrote :

Hi Jim, thanks for reporting this. I've fixed it in trunk (r305), but I cannot test it right now because vapigen is choking on the gio gir on my system.

Is there anything else I can do to make using this library from vala easier?

Changed in indicator-messages (Ubuntu):
assignee: nobody → Lars Uebernickel (larsu)
status: Confirmed → Fix Committed
status: Fix Committed → Confirmed
Changed in indicator-messages:
status: New → Fix Committed
assignee: nobody → Lars Uebernickel (larsu)
Changed in indicator-messages (Ubuntu):
assignee: Lars Uebernickel (larsu) → nobody
Changed in indicator-messages:
importance: Undecided → High
Changed in indicator-messages (Ubuntu):
importance: Undecided → High
status: Confirmed → In Progress
Lars Karlitski (larsu)
Changed in indicator-messages:
milestone: none → 12.10.3
Revision history for this message
Jim Nelson (yorba-jim) wrote :

That does it! I can now compile with Vala. Thanks for the speedy turnaround!

As far as making life easier for Vala coders, the only thing I can think of is providing Valadoc documentation. I believe Valadoc supports generating docs from .gir files.

Finally, I'm starting to port Geary to messaging-menu. Is this the best place to post bugs (assuming I find any)?

Lars Karlitski (larsu)
Changed in indicator-messages:
status: Fix Committed → Fix Released
Lars Karlitski (larsu)
Changed in indicator-messages (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.