KARL3

People ADMIN needs a heading to identify filter

Bug #1037651 reported by JimPGlenn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Low
Carlos de la Guardia
KARL3 m118

Bug Description

When updating the people listings to match GSA it would be very helpful on the edit report screen to identify which filter
is being updated. For example the departments filter is a category filter rather than a group filter. see screen shot.

Revision history for this message
JimPGlenn (jpglenn09) wrote :

screenshot of edit departments

Changed in karl3:
importance: Undecided → Low
milestone: none → m119
Paul Everitt (paul-agendaless)
Changed in karl3:
assignee: nobody → Carlos de la Guardia (cguardia)
milestone: m119 → m117
summary: - Need filter to be identified
+ People ADMIN needs a heading to identify filter
Paul Everitt (paul-agendaless)
Changed in karl3:
milestone: m117 → m118
Carlos de la Guardia (cguardia)
Changed in karl3:
status: New → In Progress
Revision history for this message
Carlos de la Guardia (cguardia) wrote :

Deployed fix to cguardia-1037651-report-filter-labels

Changed in karl3:
status: In Progress → Fix Committed
Revision history for this message
JimPGlenn (jpglenn09) wrote :

looks good

tags: added: cguardia-1037651-report-filter-labels tested ux2
JimPGlenn (jpglenn09)
tags: added: r3.97
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Carlos, when editing a report on staging, we get this traceback:

     <!--
          Traceback (most recent call last):
  File "/srv/karlstaging/staging/13/eggs/pyramid-1.2.1-py2.6.egg/pyramid/tweens.py", line 17, in excview_tween
    response = handler(request)
  File "/srv/karlstaging/staging/13/eggs/pyramid_tm-0.5-py2.6.egg/pyramid_tm/__init__.py", line 107, in tm_tween
    return response
  File "/srv/karlstaging/staging/13/eggs/pyramid_tm-0.5-py2.6.egg/pyramid_tm/__init__.py", line 75, in __exit__
    return self._retry_or_raise(t, v, tb)
  File "/srv/karlstaging/staging/13/eggs/pyramid_tm-0.5-py2.6.egg/pyramid_tm/__init__.py", line 60, in _retry_or_raise
    reraise(t, v, tb) # otherwise reraise the exception
  File "/srv/karlstaging/staging/13/eggs/pyramid_tm-0.5-py2.6.egg/pyramid_tm/__init__.py", line 100, in tm_tween
    response = handler(request)
  File "/srv/karlstaging/staging/13/eggs/pyramid-1.2.1-py2.6.egg/pyramid/router.py", line 153, in handle_request
    response = view_callable(context, request)
  File "/srv/karlstaging/staging/13/eggs/pyramid-1.2.1-py2.6.egg/pyramid/config/views.py", line 523, in __call__
    return view(context, request)
  File "/srv/karlstaging/staging/13/eggs/pyramid-1.2.1-py2.6.egg/pyramid/config/views.py", line 186, in _secured_view
    return view(context, request)
  File "/srv/karlstaging/staging/13/eggs/pyramid-1.2.1-py2.6.egg/pyramid/config/views.py", line 292, in rendered_view
    result = view(context, request)
  File "/srv/karlstaging/staging/13/eggs/pyramid_formish-0.2a1-py2.6.egg/pyramid_formish/zcml.py", line 161, in __call__
    controller = self.controller_factory(context, request)
  File "/srv/karlstaging/staging/13/src/karl/karl/views/peopledirectory.py", line 676, in __init__
    self.page_title = 'Edit %s' % self.context.label
AttributeError: 'PeopleReportGroup' object has no attribute 'label'

Changed in karl3:
status: Fix Committed → In Progress
tags: removed: r3.97 tested
Revision history for this message
JimPGlenn (jpglenn09) wrote :

looks ready for release

Changed in karl3:
status: In Progress → Fix Committed
tags: added: r3.97 tested
Revision history for this message
JimPGlenn (jpglenn09) wrote :

fixed

Changed in karl3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.