pt-query-digest won't distill LOCK TABLES in lowercase
Bug #1037211 reported by
Baron Schwartz
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Brian Fraser | ||
Bug Description
This code snippet makes 'lock tables foo f write, bar b read' fail to distill because it's lowercase:
7674 if ( $query =~ /^\s*LOCK TABLES/i ) {
7675 PTDEBUG && _d('Special table type: LOCK TABLES');
7676 $query =~ s/^(\s*LOCK TABLES\s+)//;
7677 $query =~ s/\s+(?
7678 PTDEBUG && _d('Locked tables:', $query);
7679 $query = "FROM $query";
7680 }
The problem is the lack of /i on lines 7676 and 7677.
Related branches
lp://staging/~percona-toolkit-dev/percona-toolkit/fix-1037211-distill-lowercase-lock-tables
- Daniel Nichter: Approve
-
Diff: 145 lines (+21/-23)8 files modifiedbin/pt-fingerprint (+2/-3)
bin/pt-index-usage (+2/-3)
bin/pt-query-advisor (+2/-3)
bin/pt-query-digest (+2/-3)
bin/pt-table-usage (+2/-3)
bin/pt-upgrade (+2/-3)
lib/QueryParser.pm (+2/-3)
t/lib/QueryParser.t (+7/-2)
| Changed in percona-toolkit: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| milestone: | none → 2.1.4 |
| tags: | added: case-sensitivity distill pt-query-digest |
| Changed in percona-toolkit: | |
| assignee: | nobody → Brian Fraser (fraserbn) |
| Changed in percona-toolkit: | |
| status: | Confirmed → In Progress |
| Changed in percona-toolkit: | |
| status: | In Progress → Fix Committed |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #1 |
To post a comment you must log in.
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/