Permission check broken for users on layouts (campaigns)

Bug #1035841 reported by Dan Garner
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Xibo
Fix Released
High
Dan Garner

Bug Description

I created 2 uesr's belonging to the same group. A layout created by user 1 cannot be seen by user 2. I have played around with a lot of settings but only super admin and user 1 is able to view the layout, not user 2.

Related branches

Revision history for this message
Dan Garner (dangarner) wrote :

modules/module_user_general.php

Line 1273, change to:

   $SQL = sprintf($SQL, $campaignId, implode(',', $this->GetUserGroups($this->userid, true)));

Changed in xibo:
milestone: none → 1.4.0-rc1
assignee: nobody → Dan Garner (dangarner)
status: New → Fix Committed
importance: Undecided → High
Dan Garner (dangarner)
Changed in xibo:
status: Fix Committed → Fix Released
Revision history for this message
Alex Harrington (alexharrington) wrote :

Freddy

The upgrade won't attempt to guess what permissions you want applied to the layouts. The users, or a Super Admin will need to assign appropriate permissions

Alex

Revision history for this message
Freddy Beck (rz-freddy) wrote :

Of course we set the permissions under the Layouts. It even says that both the groups and the 2 users has permissions for the layout. We we checked all three boxes (edit, delete and View). Tested for the group only (and put both users into that usergroup) and also just the two users. But if we try to edit a layout made by another user (in the group) we just get a grey picture nothing else.. not possible to edit or view pictures or timeline. just grey.. We did NOT upgrade we downloaded a new Ver 1.4.0 tarball .. and installed on a fresch LAMP Ubuntu server (nothing else installed before)..

// Freddy

Revision history for this message
Freddy Beck (rz-freddy) wrote :

Hmm Strange .. If i log in as the user that NOT is the owner of the Layout it is possible for me to change the background and add a region.. But i will only see the region that i made by the "no owner".. when i log in as the owner i can see both adds made by the owner and other users ..

// Freddy

Revision history for this message
Freddy Beck (rz-freddy) wrote :

It is the same if permissions is set to everyone...

Revision history for this message
Dan Garner (dangarner) wrote :

Freddy, I have double checked and it works on our test installation. You might want to look at right clicking on a region (regions have permissions too).

If that doesn't solve your issue, please can you open a new question for this in the Answers section.

Revision history for this message
Freddy Beck (rz-freddy) wrote :

HA .. You Just nailed it Dan !!! I thought if i give permission to the laoyut i will go recursively to the stuf on it.. BUT we noticed that the pictures and other stuff on the region has Permissions... But not the region :-)..

I now works !! Thanks a lot for help !

// Freddy

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.