TPAC - edit hold defines bad pickup locations

Bug #1034076 reported by Ben Shum
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
2.2
Fix Released
Undecided
Unassigned

Bug Description

Evergreen master

When a patron goes to edit a hold in TPAC, they have the option to choose a different pickup location. Unfortunately, it looks like that dropdown does not prevent them from selecting locations that aren't normally allowed for pickups, such as system groups or consortium itself.

Probably need to find the logic used in other parts of TPAC that define holdable pickup locations and change this.

Credit to Melissa Lefebvre for finally nailing down the source of the issue.

Revision history for this message
Ben Shum (bshum) wrote :
tags: added: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Probably affects 2.2 series' TPAC as well.

Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Thanks for this! In master, rel_2_3 and rel_2_2 after testing.

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.