Assertion in nethost is always true
Bug #1033213 reported by
Hans Joachim Desserud
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
Found by enabling -Wlogical-op option in GCC:
/home/arch/
Since or is used, the assertion is always true. Use 'and' instead?
PS. I'm experimenting a bit with additional warning options. More on this later.
| description: | updated |
Revision history for this message
| Nasenbaer (nasenbaer) wrote | #1 |
| Changed in widelands: | |
| assignee: | nobody → Nasenbaer (nasenbaer) |
| status: | New → Confirmed |
| milestone: | none → build18-rc1 |
Revision history for this message
| Nasenbaer (nasenbaer) wrote | #2 |
| Changed in widelands: | |
| status: | Confirmed → Fix Committed |
| Changed in widelands: | |
| assignee: | Nasenbaer (nasenbaer) → nobody |
Revision history for this message
| SirVer (sirver) wrote | #3 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
You are completely right. This is indeed a bug - as it is an assert, it's not that problematic, should be fixed anyway.
Good that I know the guy who wrote that part of te code ;) ... he told me that it was meant to be a && ;)
I will take care of the fix.
Thanks for finding this bug Hans Joachim :)