Trying to update patron CSS color fails at message editing, so don't try

Bug #1029650 reported by Lebbeous Fogle-Weekley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.3
Fix Released
Medium
Unassigned

Bug Description

For Evergreen 2.2+:

    Trying to update patron CSS color fails here, so don't try

    After modifying user standing penalties ("messages" in the staff client
    patron interface), you could get this error message in an alert() dialog:
        TypeError: patron.display is undefined.

    We were apparently trying to use patron.util.set_patron_css() wrongly,
    so the commented out changed verison of the call got farther, but stopped at
        ...penalties[i].standing_penalty().name is not a function.

    Which probably has something to do with unfleshed data. Somebody can
    get to the bottom of this if they want, but for now it's easier just not
    to try to do this and make the alert() dialog go away.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/senator/patron-display-undefined

Tags: pullrequest
Changed in evergreen:
importance: Undecided → Low
importance: Low → Medium
Changed in evergreen:
milestone: 2.2.1 → 2.2.2
Revision history for this message
Bill Erickson (berick) wrote :

That is indeed annoying. Agreed on avoiding the alert as a first step. Tested and pushed to master, rel_2_3, and rel_2_2.

Changed in evergreen:
assignee: nobody → Bill Erickson (erickson-esilibrary)
status: New → In Progress
status: In Progress → Fix Committed
assignee: Bill Erickson (erickson-esilibrary) → nobody
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.