Connection lost after some time if all players pause in multiplayer
Bug #1027058 reported by
Johannes Ebke
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
In a two-player direct IP game over the internet (bzr6417), we observed that when both players pause the game (for example for dinner), the connection silently drops after some time.
This is probably since a widelands-ping is only sent if one of the clients forces a wait, but not if the players agree to pause. I will push a fix momentarily, which however has only been tested locally yet.
Related branches
lp://staging/~ebke/widelands/ping-on-pause
- Widelands Developers: Pending requested
-
Diff: 15 lines (+3/-2)1 file modifiedsrc/network/nethost.cc (+3/-2)
Revision history for this message
| Nasenbaer (nasenbaer) wrote | #1 |
| Changed in widelands: | |
| status: | New → Confirmed |
| milestone: | none → build18-rc1 |
Revision history for this message
| Shevonar (shevonar) wrote | #2 |
Revision history for this message
| Shevonar (shevonar) wrote | #3 |
| Changed in widelands: | |
| status: | Confirmed → Fix Committed |
| importance: | Undecided → Medium |
Revision history for this message
| SirVer (sirver) wrote | #4 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Oh you are right, haven't thought about the "normal" case, when implementing the forcedPause fix :-D
Thank you for the patch!