Scratch

Don't use FileUtils.set_contents()

Bug #1021860 reported by Sergey "Shnatsel" Davidoff on 2012-07-06

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Feedler	Fix Committed	Low	Marcus Lundgren
Footnote	Fix Committed	Undecided	Marcus Lundgren
Maya	Fix Released	Undecided	Marcus Lundgren	Maya 0.1 "Patrick Star"
Midori Web Browser	Invalid	Undecided	Unassigned
Scratch	Fix Released	Undecided	Unassigned	Scratch 1.1.1

Bug Description

Do not use FileUtils.set_contents() also known as g_file_set_contents() for overwriting files, because it resets file permissions to default permissive policy and can potentially expose files that were made private. Its behavior of creating a new file and substituting the old one with it also makes the older file impossible to shred and makes automated data recovery harder on many filesystems.
GIO function document.file.replace_contents() should be used instead.

See http://valadoc.org/#!api=gio-2.0/GLib.File.replace_contents for documentation. There's also replace_contents_async() which can be useful.
An example of transitioning code to that function can be found in http://bazaar.launchpad.net/~elementary-apps/scratch/scratch/revision/782 in Tab.Vala

I'm marking all projects in which I've grepped either form of this function as affected.

See original description

Related branches

lp://staging/~marcus-lundgren/maya/fix-1021860

Merged into lp://staging/~elementary-apps/maya/trunk at revision 328

Niels Avonds (community): Approve on 2012-07-23

lp://staging/~marcus-lundgren/feedler/fix-1021860

Merged into lp://staging/feedler at revision 313

Daniel Kur: Pending requested 2012-07-23

lp://staging/~marcus-lundgren/footnote/fix-1021860

Merged into lp://staging/footnote at revision 279

Tom Beckmann (community): Approve on 2012-07-25

Sergey "Shnatsel" Davidoff (shnatsel) on 2012-07-06

Changed in scratch:
status:	New → Fix Committed
description:	updated

Mario Guerriero (mefrio-g) on 2012-07-07

Changed in scratch:
milestone:	none → luna-beta1
Changed in maya:
milestone:	none → 0.1-luna-beta1

Sergey "Shnatsel" Davidoff (shnatsel) on 2012-07-08

description:

updated

Marcus Lundgren (marcus-lundgren) on 2012-07-23

Changed in maya:
assignee:	nobody → Marcus Lundgren (marcus-lundgren)
status:	New → In Progress

Marcus Lundgren (marcus-lundgren) on 2012-07-23

Changed in feedler:
assignee:	nobody → Marcus Lundgren (marcus-lundgren)
status:	New → In Progress

Marcus Lundgren (marcus-lundgren) on 2012-07-23

Changed in footnote:
assignee:	nobody → Marcus Lundgren (marcus-lundgren)
status:	New → In Progress

Niels Avonds (niels-avonds) on 2012-07-24

Changed in maya:
status:	In Progress → Fix Committed

Danielle Foré (danrabbit) on 2012-08-03

Changed in scratch:
status:	Fix Committed → Fix Released

Danielle Foré (danrabbit) on 2012-10-12

Changed in maya:
status:	Fix Committed → Fix Released

Jaap Broekhuizen (jaapz-b) on 2012-11-12

Changed in footnote:
status:	In Progress → Fix Committed

Cris Dywan (kalikiana) on 2012-12-08

Changed in midori:
status:	New → Fix Committed
status:	Fix Committed → Invalid

Marcus Lundgren (marcus-lundgren) on 2013-02-28

Changed in feedler:
status:	In Progress → Fix Committed

Daniel Kur (daniel-m-kur) on 2013-05-05

Changed in feedler:
importance:	Undecided → Low

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.