Evergreen

TPAC: Search wrapper spacing

Bug #1020646 reported by Melissa Lefebvre
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Dan Scott
Evergreen 2.3.0-alpha2
2.2
Fix Released
Undecided
Unassigned
Evergreen 2.2.1

Bug Description

Evergreen version: master

Currently the search box options are "smooshed up" against the links toolbar. The following changes address this.

Padding was added to style.css search_box_wrapper in order to bring the "Search the Catalog" down lower from the link toolbar.

Padding was also added to the searchbar.tt2 in order to bring the search filter options down lower from the "Search the Catalog" wording.

Branch at: user/melissa/tpac_spacing

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/melissa/tpac_spacing

Revision history for this message
Michael Peters (mrpeters) wrote :

Tested, and working. Just not sure it makes a huge difference. I do notice some difference, but perhaps it's because I didn't have any trouble with legibility, that I don't notice it much.

In my opinion, I don't see any problem with merging this, if there are people who are having trouble with readability.

Ben Shum (bshum)
Changed in evergreen:
importance: Undecided → Wishlist
status: New → Triaged
milestone: none → 2.3.0-alpha2
Revision history for this message
Melissa Lefebvre (mlefebvre) wrote :

Oops, sorry forgot to include the additional css padding changes for #search-wrapper #search-box .

Force pushed revised commit to my working branch.

Dan Scott (denials)
Changed in evergreen:
assignee: nobody → Dan Scott (denials)
Revision history for this message
Dan Scott (denials) wrote :

Thanks, Melissa, I like the resulting change; it feels less claustraphobic! One direction we've been headed, though, is to reduce our inline CSS, so to that end I've pushed an additional commit on top of your commit into my branch at user/dbs/tpac_spacing

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/tpac_spacing

If you can sign off on that commit, I'll push the lot into Evergreen 2.3 in time for Wednesday's alpha-2.

Revision history for this message
Melissa Lefebvre (mlefebvre) wrote :

Test and working wonderfully.

 I've pushed everything to http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/melissa/tpac_spacing2

Revision history for this message
Dan Scott (denials) wrote :

Awesome, thanks Melissa! Pushed to master and rel_2_2 as a fix for claustrophobia :)

Changed in evergreen:
status: Triaged → Fix Committed
Jason Stephenson (jstephenson)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.