Silva

mangle.Id should restrict Ids they way the 'add' screen describes it.

Bug #101800 reported by Andy Altepeter
6
Affects Status Importance Assigned to Milestone
Silva
Fix Released
Wishlist
Eric Casteleijn
Silva 1.6

Bug Description

The add screen says no spaces are allowed, but mangle.Id._valid_id (even in
trunk) allows spaces so long as they aren't the first character.

I've applied this change to the Silva trunk, but it should probably be
backported to the other Silva releases (1.6, 1.5.10, other?)

Tags: silva-1.6
Revision history for this message
Eric Casteleijn (thisfred) wrote :

Trunk is still 1.6, so we only need to port it back to 1.5. I'll do
that. Thanks Andy. Allowing the spaces *was* a conscious decision at the
time, I believe, when Zope started allowing them in ids. I just believe
it was a very bad decision....

Revision history for this message
Eric Casteleijn (thisfred) wrote :

Actually, since the entire 1.5 branch has had this, maybe people are
relying on it. So I won't back port. I do have to look into an upgrade
script for 1.6.

Revision history for this message
Kit Blake (kitblake) wrote :

Thisfred, this is still a todo, right? Assigning to you, for after the final.

You need to do something with upgrade and/or the import? People will import
content from 1.5, with spaces, to 1.6.

Revision history for this message
Eric Casteleijn (thisfred) wrote :

No, this has been done for 1.6, and we won't do it for 1.5. I'll have one last
test with importing 1.5 documentation into 1.6.

Revision history for this message
Eric Casteleijn (thisfred) wrote :

This works just fine. Capitals are still allowed, which I'm not too happy about,
but then they aren't mentioned in the add screen.

Andy Altepeter (aaltepet)
Changed in silva:
milestone: none → 1.6
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.