modebutton returning a wrong index
Bug #1017231 reported by
DavyS
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Granite |
Fix Released
|
High
|
Victor Martinez | ||
Bug Description
the modebutton widget return a wrong index.
line 155: "int item_index = (int)get_children ().length ();"
should be "length () -1" because length start with 1 and index start with 0.
Related branches
lp://staging/~victored/granite/utils
- Cody Garver (community): Approve
-
Diff: 935 lines (+264/-250)12 files modifiedlib/CMakeLists.txt (+1/-0)
lib/GtkPatch/AboutDialog.vala (+5/-21)
lib/Widgets/AboutDialog.vala (+8/-15)
lib/Widgets/CompositedWindow.vala (+8/-19)
lib/Widgets/DecoratedWindow.vala (+10/-22)
lib/Widgets/ModeButton.vala (+33/-61)
lib/Widgets/PopOver.vala (+3/-10)
lib/Widgets/SidebarPaned.vala (+59/-45)
lib/Widgets/StatusBar.vala (+4/-21)
lib/Widgets/ToolButtonWithMenu.vala (+3/-14)
lib/Widgets/Utils.vala (+121/-0)
lib/Widgets/Welcome.vala (+9/-22)
Revision history for this message
| Sergey "Shnatsel" Davidoff (shnatsel) wrote | #1 |
| tags: | added: bitesize |
| Changed in granite: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| Changed in granite: | |
| status: | Confirmed → Fix Committed |
| assignee: | nobody → Victor Eduardo (victored) |
| milestone: | none → luna-beta1 |
| Changed in granite: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Can any of the devs confirm this?