Mipmap support broken
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Compiz |
In Progress
|
High
|
Sam Spilsbury | ||
Bug Description
Mipmapping support appears to be broken in several ways
1. glGenerateMipmapEXT is called multiple times for tfp textures
2. glGenerateMipmapEXT is called after glTexParameteri with GL_LINEAR_
3. We check for GL::fbo support before actually setting it from the extension lookup after glXCreateContext is called. As such, when we lookup an optimal pixmap fbconfig, we never find one that supports mipmaps, and it is merely "luck of the draw" as to whether or not we actually get one that does
4. We generate mipmaps for tfp textures even though mipmaps aren't actually supported on the config target, because we don't check priv->mipmapSupport
This generally results in white windows when mipmapping is enabled. See bug 1006216 and bug 729979 (which I suspect is happening because someone enables mipmaps on the animated windows)
Related branches
- Sam Spilsbury: Needs Resubmitting
- Daniel van Vugt: Needs Fixing
-
Diff: 170 lines (+47/-26)5 files modifiedplugins/opengl/include/opengl/opengl.h (+1/-1)
plugins/opengl/include/opengl/texture.h (+5/-0)
plugins/opengl/src/privatetexture.h (+1/-0)
plugins/opengl/src/screen.cpp (+7/-9)
plugins/opengl/src/texture.cpp (+33/-16)
| Changed in compiz: | |
| status: | New → In Progress |
| assignee: | nobody → Sam Spilsbury (smspillaz) |
| importance: | Undecided → High |
| milestone: | none → 0.9.8.0 |
| MC Return (mc-return) wrote | #1 |
| Daniel van Vugt (vanvugt) wrote | #2 |
| Changed in compiz: | |
| milestone: | 0.9.8.0 → 0.9.8.1 |
| Changed in compiz: | |
| milestone: | 0.9.8.2 → 0.9.8.4 |
| Changed in compiz: | |
| milestone: | 0.9.8.4 → 0.9.9.0 |
| Changed in compiz: | |
| milestone: | 0.9.9.0 → 0.9.9.2 |
| Changed in compiz: | |
| milestone: | 0.9.9.2 → 0.9.10.0 |
| Changed in compiz: | |
| milestone: | 0.9.10.0 → 0.9.10.2 |
| Changed in compiz: | |
| milestone: | 0.9.10.2 → 0.9.11.0 |
Is this related to bug 1009566 / bug 913521 ?