Remove widelands-bundled minizip sources for Debian

As I understand minizip is a small example for zlib. The minizip progam on ubuntu (zlib-bin) use zlib and no other library, so I ask me is there a special minizip library? Or is this only a striped zlib?

And why widelands do not use zlib for the "minizip tasks" too? Widelands alreday depends on zlib so this step would not add an additional dependency.

The main difference is, that zip can handle multiple files, while gzip is only able to compress one file and zlib is not able to decompress zip archives which contain more than one file.

http://www.zlib.net/zlib_faq.html#faq11

@#1:

You are right, minizip is an example by zlib people how to use zlib, packed in a separate small library which compiles and links against zlib.
It does not belong to the core zlib library. However, a few linux distributions bundle them up nevertheless, as it is really useful. #3 has written why.

As this is a really useful library, but not available everywhere, many projects decided to use the minizip sources within their packages, but not link against a system minizip library. Next to your favourite example widelands I can mention vlc as most prominent example.

Difference now is, that with vlc there is some power in the market, and there have been changes in the zlib api which prevents older minizip sources to compile against modern zlib. It seems to me that there is a general movement that soon all major distributions support a system minizip library.

So, minizip is not zlib, minizip can not be replaced easily by zlib.

okey, thanks for making this clear.

Not possible for build18 -> build19

has not happened so far. Bundling minizip with Widelands is fine, we do that for other libraries too. Static linking is the way of the future anyways.

Debian will ship a minizip library: Bug #1182025
or direct to debian bug list: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=709803

Hopefully libminizip will be in the next ubuntu release ;)

Borim: thanks for following up on this one.

At this point of the development cycle, Ubuntu is automatically syncing packages from Debian, so it is already in! :) See https://launchpad.net/ubuntu/+source/minizip for details.

Homebrew now also has minizip - so this seems more and more realistic.

We have to bring back the conditional inclusion of the bundled stuff though - it was removed some time ago.

Than reopen the bug, so it does not get lost.

Setting to incomplete for bug sweeping.

Nobody has mentioned Windows in this discussion - a library & exe can be downloaded from

http://www.winimage.com/zLibDll/minizip.html

I have found Minizip packages for:

Arch
CentOS
Debian
Fedora
FreeBSD
Gentoo
Mageia
Mint
OpenMandriva
openSUSE
PCLinuxOS
Rawhide
ROSA
Scientific Linux
Slackware
Ubuntu

http://rpmfind.net/linux/rpm2html/search.php?query=minizip&submit=Search+...&system=&arch=
https://pkgs.org/download/libminizip.so.1%28%29%2864bit%29
http://rpm.pbone.net/index.php3/stat/3/srodzaj/1/search/libminizip.so.1
http://www.freshports.org/archivers/minizip/
http://packages.ubuntu.com/xenial/utils/minizip
https://www.archlinux.org/packages/community/x86_64/minizip/
https://slackbuilds.org/repository/13.37/libraries/libminizip/
https://community.linuxmint.com/software/view/zlib-bin
https://packages.gentoo.org/useflags/minizip

So, if we want to do this, we should be covered.

Windows is always a problem... and i am not familiar with it any more. Could the download/install be started automatically? Who is responsible for a secure third party minizip library? Where does the enduser be told that minizip is a prerequisite and where he could get it?

The minizip.src in widelands has a size of 88KiB. Because of the little size i am in favour of rescheduling this bug.

Maybe related: "Files in .wmf files have no timestamps", bug 1568457

I am still of the opinion that what I said in 6 is the best approach. Let's close this and keep using the version we have in our repo.

Agreed.

It's a Debian requirement not to include generally available libraries, so we need an option not to use our bundled minizip.

Migrated to https://github.com/widelands/widelands/issues/399