pack-on-the-fly heuristic probably inaccurate for chk groups
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
High
|
Unassigned | ||
Breezy |
Triaged
|
Medium
|
Unassigned |
Bug Description
Somewhat related to bug #402662.
The current 'insert_
The heuristic is a bit weak, though, as it assumes that any group that isn't larger than X should be repacked. I *think* this causes us to often repack all chk pages during fetch. At least, I think I've seen a lot of 'bzr branch' times that I thought would be bandwidth bound, but showed up as CPU bound.
I haven't dug deep enough to fully confirm this bug, but I wanted to make sure not to forget about it.
There are also probably a few possible fixes
1) Work on bug #402662 to pack more chk nodes in a single group, thus working with the current heuristic.
2) Postpone the recompression until the *next* group is read. This will help when we have the sub-stream which has a single group in it (for all related chk pages). We don't need to recompress because we don't have any other data to *put* into that group. However, it is slightly at odds with the "don't buffer" desire for 'get_record_
3) Come up with some other heuristic for chk nodes.
tags: | added: packs |
tags: | added: check-for-breezy |
tags: |
added: performance removed: check-for-breezy |
Changed in brz: | |
status: | New → Triaged |
importance: | Undecided → Medium |