pre_commit hook overly expensive - should lazily compute parameters

Bug #189431 reported by Robert Collins
Affects Status Importance Assigned to Milestone
Jelmer Vernooij

Bug Description

the Branch.pre_commit hook calculates a delta and revision tree object
that may not be needed or used, when a hook is present. This is partly
due to the signature - a Result (confusing name which this is before the
operation) - perhaps a PreCommitEvent? object should be passed into the
hook calls, and it can generate content on demand and cache it after
generating. This will make the debate about how shell hooks should fit
in simpler too.

 affects bzr
GPG key available at: <>.

Martin Pool (mbp)
Changed in bzr:
importance: Undecided → Medium
status: New → Confirmed
Jelmer Vernooij (jelmer)
tags: added: commit hooks performance
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
tags: removed: check-for-breezy
Changed in brz:
importance: Undecided → Medium
status: New → Triaged
assignee: nobody → Jelmer Vernooij (jelmer)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.