brz not working on bitbucket git repo

The attached branch fixes access of URLs like https://<email address hidden>/bitexploration/integriticheck.git

rcp-style URLs (e.g. <email address hidden>:bitexploration/integriticheck.git) are not supported, but there is another pending branch that will improve the error message when you attempt to use them.

I just went through the changes, and I discovered that, in git/__init__.py, lines 151, 152 and 153 are doing same to lines 663, 664, 665 in git/remote.py. Is it not good to put it in a function to make future maintenance easier?

Thanks

That's hard to do without adding extra overhead for the non-git case (importing from the other module) to the probing process.

As indicated in the review, we should really bee end to end tests for git over http.

On 14 February 2019 12:05:25 GMT, Sunday Olutayo <email address hidden> wrote:
>I just went through the changes, and I discovered that, in
>git/__init__.py, lines 151, 152 and 153 are doing same to lines 663,
>664, 665 in git/remote.py. Is it not good to put it in a function to
>make future maintenance easier?
>
>Thanks
>
>--
>You received this bug notification because you are a bug assignee.
>https://bugs.launchpad.net/bugs/1815828
>
>Title:
> brz not working on bitbucket git repo
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/brz/+bug/1815828/+subscriptions

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Okay, it will be nice, if there is a sort of guidance or introduction,
that will help new and potential contributors to understand the breezy
code base.

Thanks

On 14/02/2019 5:48 PM, Jelmer Vernooij wrote:
> That's hard to do without adding extra overhead for the non-git case
> (importing from the other module) to the probing process.
>
> As indicated in the review, we should really bee end to end tests for
> git over http.
>
> On 14 February 2019 12:05:25 GMT, Sunday Olutayo <email address hidden> wrote:
>> I just went through the changes, and I discovered that, in
>> git/__init__.py, lines 151, 152 and 153 are doing same to lines 663,
>> 664, 665 in git/remote.py. Is it not good to put it in a function to
>> make future maintenance easier?
>>
>> Thanks
>>
>> --
>> You received this bug notification because you are a bug assignee.
>> https://bugs.launchpad.net/bugs/1815828
>>
>> Title:
>> brz not working on bitbucket git repo
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/brz/+bug/1815828/+subscriptions
>

See https://breezy-vcs.org/developers/index.html for the developer documentation. Also happy to answer questions on IRC/the mailing list.

On 14 February 2019 17:12:03 GMT, Sunday Olutayo <email address hidden> wrote:
>Okay, it will be nice, if there is a sort of guidance or introduction,
>that will help new and potential contributors to understand the breezy
>code base.
>
>Thanks
>
>
>On 14/02/2019 5:48 PM, Jelmer Vernooij wrote:
>> That's hard to do without adding extra overhead for the non-git case
>> (importing from the other module) to the probing process.
>>
>> As indicated in the review, we should really bee end to end tests for
>> git over http.
>>
>> On 14 February 2019 12:05:25 GMT, Sunday Olutayo
><email address hidden> wrote:
>>> I just went through the changes, and I discovered that, in
>>> git/__init__.py, lines 151, 152 and 153 are doing same to lines 663,
>>> 664, 665 in git/remote.py. Is it not good to put it in a function to
>>> make future maintenance easier?
>>>
>>> Thanks
>>>
>>> --
>>> You received this bug notification because you are a bug assignee.
>>> https://bugs.launchpad.net/bugs/1815828
>>>
>>> Title:
>>> brz not working on bitbucket git repo
>>>
>>> To manage notifications about this bug go to:
>>> https://bugs.launchpad.net/brz/+bug/1815828/+subscriptions
>>
>
>--
>You received this bug notification because you are a bug assignee.
>https://bugs.launchpad.net/bugs/1815828
>
>Title:
> brz not working on bitbucket git repo
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/brz/+bug/1815828/+subscriptions

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

How can one apply this "Fix Released" to an existing installation.

Thanks

On Sat, Feb 16, 2019 at 09:22:24AM -0000, Sunday Olutayo wrote:
> How can one apply this "Fix Released" to an existing installation.
Rather than applying this change to an existing installation, the
easiest thing to do is probably to switch to running Breezy out of
trunk:

https://www.breezy-vcs.org/doc/en/user-guide/installing_breezy.html?highlight=installation#running-the-development-version

Jelmer

--
Jelmer Vernooij <email address hidden>
PGP Key: https://www.jelmer.uk/D729A457.asc

I tried running Breezy out of trunk, but this is what I got:

$ brz whoami

Traceback (most recent call last):

  1 File "/opt/brz/brz", line 92, in <module>

  2 with breezy.initialize():

  3 File "/opt/brz/breezy/__init__.py", line 213, in initialize

  4 ui_factory = breezy.ui.make_ui_for_terminal(stdin, stdout,
stderr)

  5 File "/opt/brz/breezy/ui/__init__.py", line 526, in
make_ui_for_terminal

  6 from .text import TextUIFactory

  7 File "/opt/brz/breezy/ui/text.py", line 38, in <module>

  8 from .. import (

  9 File "/opt/brz/breezy/config.py", line 81, in <module>

 10 import configobj

 11 ImportError: No module named configobj

I searched the breezy directory, this no configobj file.

Thanks,
Sunday Olutayo

On 16/02/2019 4:04 PM, Jelmer Vernooij wrote:
> On Sat, Feb 16, 2019 at 09:22:24AM -0000, Sunday Olutayo wrote:
>> How can one apply this "Fix Released" to an existing installation.
> Rather than applying this change to an existing installation, the
> easiest thing to do is probably to switch to running Breezy out of
> trunk:
>
> https://www.breezy-vcs.org/doc/en/user-
> guide/installing_breezy.html?highlight=installation#running-the-
> development-version
>
> Jelmer
>

On Sun, Feb 17, 2019 at 05:10:11PM -0000, Sunday Olutayo wrote:
> I tried running Breezy out of trunk, but this is what I got:

>
> $ brz whoami
>
> Traceback (most recent call last):
>
>
> 1 File "/opt/brz/brz", line 92, in <module>
>
>
> 2 with breezy.initialize():
>
>
> 3 File "/opt/brz/breezy/__init__.py", line 213, in initialize
>
>
> 4 ui_factory = breezy.ui.make_ui_for_terminal(stdin, stdout,
> stderr)
>
> 5 File "/opt/brz/breezy/ui/__init__.py", line 526, in
> make_ui_for_terminal
>
>
> 6 from .text import TextUIFactory
>
>
> 7 File "/opt/brz/breezy/ui/text.py", line 38, in <module>
>
>
> 8 from .. import (
>
>
> 9 File "/opt/brz/breezy/config.py", line 81, in <module>
>
>
> 10 import configobj
>
>
> 11 ImportError: No module named configobj
>
> I searched the breezy directory, this no configobj file.
configobj is an external module. Running "python setup.py install"
(as described in the installation documentation) should pull it in.

Jelmer

>
> On 16/02/2019 4:04 PM, Jelmer Vernooij wrote:
> > On Sat, Feb 16, 2019 at 09:22:24AM -0000, Sunday Olutayo wrote:
> >> How can one apply this "Fix Released" to an existing installation.
> > Rather than applying this change to an existing installation, the
> > easiest thing to do is probably to switch to running Breezy out of
> > trunk:
> >
> > https://www.breezy-vcs.org/doc/en/user-
> > guide/installing_breezy.html?highlight=installation#running-the-
> > development-version
> >
> > Jelmer
> >
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1815828
>
> Title:
> brz not working on bitbucket git repo
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/brz/+bug/1815828/+subscriptions

--
Jelmer Vernooij <email address hidden>
PGP Key: https://www.jelmer.uk/D729A457.asc

On Sun, Feb 17, 2019 at 05:44:47PM +0000, Jelmer Vernooij wrote:
> On Sun, Feb 17, 2019 at 05:10:11PM -0000, Sunday Olutayo wrote:
> > I tried running Breezy out of trunk, but this is what I got:
>
> >
> > $ brz whoami
> >
> > Traceback (most recent call last):
> >
> >
> > 1 File "/opt/brz/brz", line 92, in <module>
> >
> >
> > 2 with breezy.initialize():
> >
> >
> > 3 File "/opt/brz/breezy/__init__.py", line 213, in initialize
> >
> >
> > 4 ui_factory = breezy.ui.make_ui_for_terminal(stdin, stdout,
> > stderr)
> >
> > 5 File "/opt/brz/breezy/ui/__init__.py", line 526, in
> > make_ui_for_terminal
> >
> >
> > 6 from .text import TextUIFactory
> >
> >
> > 7 File "/opt/brz/breezy/ui/text.py", line 38, in <module>
> >
> >
> > 8 from .. import (
> >
> >
> > 9 File "/opt/brz/breezy/config.py", line 81, in <module>
> >
> >
> > 10 import configobj
> >
> >
> > 11 ImportError: No module named configobj
> >
> > I searched the breezy directory, this no configobj file.
> configobj is an external module. Running "python setup.py install"
> (as described in the installation documentation) should pull it in.

Alternatively, you can install it by running "pip install configobj"

Jelmer

> > On 16/02/2019 4:04 PM, Jelmer Vernooij wrote:
> > > On Sat, Feb 16, 2019 at 09:22:24AM -0000, Sunday Olutayo wrote:
> > >> How can one apply this "Fix Released" to an existing installation.
> > > Rather than applying this change to an existing installation, the
> > > easiest thing to do is probably to switch to running Breezy out of
> > > trunk:
> > >
> > > https://www.breezy-vcs.org/doc/en/user-
> > > guide/installing_breezy.html?highlight=installation#running-the-
> > > development-version
> > >
> > > Jelmer
> > >
> >
> > --
> > You received this bug notification because you are a bug assignee.
> > https://bugs.launchpad.net/bugs/1815828
> >
> > Title:
> > brz not working on bitbucket git repo
> >
> > To manage notifications about this bug go to:
> > https://bugs.launchpad.net/brz/+bug/1815828/+subscriptions
>
> --
> Jelmer Vernooij <email address hidden>
> PGP Key: https://www.jelmer.uk/D729A457.asc

--
Jelmer Vernooij <email address hidden>
PGP Key: https://www.jelmer.uk/D729A457.asc

It is working now.

Thanks,
Sunday Olutayo

On 17/02/2019 6:49 PM, Jelmer Vernooij wrote:
> On Sun, Feb 17, 2019 at 05:44:47PM +0000, Jelmer Vernooij wrote:
>> On Sun, Feb 17, 2019 at 05:10:11PM -0000, Sunday Olutayo wrote:
>>> I tried running Breezy out of trunk, but this is what I got:
>>
>>>
>>> $ brz whoami
>>>
>>> Traceback (most recent call last):
>>>
>>>
>>> 1 File "/opt/brz/brz", line 92, in <module>
>>>
>>>
>>> 2 with breezy.initialize():
>>>
>>>
>>> 3 File "/opt/brz/breezy/__init__.py", line 213, in initialize
>>>
>>>
>>> 4 ui_factory = breezy.ui.make_ui_for_terminal(stdin, stdout,
>>> stderr)
>>>
>>> 5 File "/opt/brz/breezy/ui/__init__.py", line 526, in
>>> make_ui_for_terminal
>>>
>>>
>>> 6 from .text import TextUIFactory
>>>
>>>
>>> 7 File "/opt/brz/breezy/ui/text.py", line 38, in <module>
>>>
>>>
>>> 8 from .. import (
>>>
>>>
>>> 9 File "/opt/brz/breezy/config.py", line 81, in <module>
>>>
>>>
>>> 10 import configobj
>>>
>>>
>>> 11 ImportError: No module named configobj
>>>
>>> I searched the breezy directory, this no configobj file.
>> configobj is an external module. Running "python setup.py install"
>> (as described in the installation documentation) should pull it in.
>
> Alternatively, you can install it by running "pip install configobj"
>
> Jelmer
>
>>> On 16/02/2019 4:04 PM, Jelmer Vernooij wrote:
>>>> On Sat, Feb 16, 2019 at 09:22:24AM -0000, Sunday Olutayo wrote:
>>>>> How can one apply this "Fix Released" to an existing installation.
>>>> Rather than applying this change to an existing installation, the
>>>> easiest thing to do is probably to switch to running Breezy out of
>>>> trunk:
>>>>
>>>> https://www.breezy-vcs.org/doc/en/user-
>>>> guide/installing_breezy.html?highlight=installation#running-the-
>>>> development-version
>>>>
>>>> Jelmer
>>>>
>>>
>>> --
>>> You received this bug notification because you are a bug assignee.
>>> https://bugs.launchpad.net/bugs/1815828
>>>
>>> Title:
>>> brz not working on bitbucket git repo
>>>
>>> To manage notifications about this bug go to:
>>> https://bugs.launchpad.net/brz/+bug/1815828/+subscriptions
>>
>> --
>> Jelmer Vernooij <email address hidden>
>> PGP Key: https://www.jelmer.uk/D729A457.asc
>
>