Installing brz does not install gpg / brz does not handle missing gpg clearly
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Breezy |
Fix Released
|
High
|
Jelmer Vernooij | ||
Bug Description
When I tried to commit with brz, I got:
$ brz commit -m "Wait for postgres to be ready instead of sleeping."
Committing to: /home/abentley/
modified bin/docker-
brz: ERROR: No module named gpg
You may need to install this Python library separately.
This is because my old ~/.bazaar/
If it is intended that Breezy can be installed without support for signing, then when it is missing a more specific error would be helpful. (I used -Derror to figure this out.) Something like:
You have enabled signing commits, but the gpg Python library is not installed. You can either install the gpg library or set create_
Related branches
- Martin Packman: Approve
-
Diff: 37 lines (+10/-3)1 file modifiedbreezy/gpg.py (+10/-3)
| Jelmer Vernooij (jelmer) wrote | #1 |
| Changed in brz: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| milestone: | none → 3.0.0 |
| tags: | added: gpg |
| Changed in brz: | |
| status: | Triaged → Fix Committed |
| Changed in brz: | |
| status: | Fix Committed → Fix Released |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
We should indeed at least show a clearer error message here.
I'm not sure about depending on gpg for all installations, because of the number of dependencies we'd pull in (the gpg binary and all its dependencies).
We can register an 'extra' for gpg signatures so that you can install 'breezy[pgp]' to pull in the right dependencies, but that's of course a lot less discoverable.