collisions through uploading same-named .pack files not handled correctly
Bug #165293 reported by
Robert Collins
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Confirmed
|
High
|
Unassigned | ||
| Breezy |
Triaged
|
Medium
|
Unassigned | ||
Bug Description
hash collisions in the packs list are not handled as robustly as needed
for for widespread use. Specifically the indices are not renamed into
place, and the content-is-same check is not performed. This also impacts
the removal-of-old packs logic which could potentially race with
uploads, so this needs to be assessed. (We need to
get names-list-lock
merge the names into memory
check our pack name is not now-present
rename into place
write the names list
release the lock
affects bzr
tag packs
status triaged
--
GPG key available at: <http://
| Changed in bzr: | |
| importance: | Undecided → High |
| status: | Triaged → Confirmed |
Revision history for this message
| John A Meinel (jameinel) wrote | #1 |
Revision history for this message
| Robert Collins (lifeless) wrote Re: [Bug 165293] Re: collisions through uploading same-named .pack files not handled correctly | #2 |
| tags: | added: check-for-breezy |
| Changed in brz: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| tags: | removed: check-for-breezy |
To post a comment you must log in.
Are we assuming that if there is a name conflict then the packs are identical?
Or do we also need to grab at least the indexes and make sure that they have identical data.