create_pack_from_packs should check that knit compression parents are present

Bug #156091 reported by Martin Pool
Affects Status Importance Assigned to Milestone

Bug Description

The create_pack_from_packs code is used when fetching from one pack repository to another. (And also, or something similar is used, when fetching to and from knits.) This copies the compressed knit hunks for speed. It doesn't check that the knit compression parents are present, which allows situations like that of bug 155730.

Robert suggests that the check will be much more efficient if we remember the compression parents as we copy records, then check for all of them at the end.

We would have the option of giving a warning or error, or additionally copying the parents.

Tags: packs
Revision history for this message
Martin Pool (mbp) wrote :

This isn't a problem when pulling from knits to packs as that uses the knit index to decide what to copy.

Changed in bzr:
importance: Undecided → High
status: New → Confirmed
Jelmer Vernooij (jelmer)
tags: added: packs
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
tags: removed: check-for-breezy
Changed in brz:
status: New → Triaged
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.