reader: use unambiguous page reference in url when there are duplicate page assertions

Bug #383394 reported by mangtronix
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Internet Archive BookServer
Confirmed
Medium
mangtronix

Bug Description

More than one page may be asserted to be the same number. For example in this book the pages with Roman numerals have integer page number assertions so there ends up being two pages that are "Page 6".

http://www.archive.org/stream/librariesoffutur00lickuoft#page/6/mode/1up
http://www.archive.org/stream/librariesoffutur00lickuoft#page/n27/mode/1up

To disambiguate the page numbers in the URL we could use the "n" prefixed page indices.

Tags: qa-verified
mangtronix (mang)
Changed in bookserver:
assignee: nobody → mangtronix (mang)
importance: Undecided → Medium
status: New → Confirmed
mangtronix (mang)
summary: - use unambiguous page reference in url when there are duplicate page
- assertions
+ reader: use unambiguous page reference in url when there are duplicate
+ page assertions
Changed in gnubook:
assignee: nobody → mangtronix (mang)
importance: Undecided → High
milestone: none → 0.9.8
status: New → Confirmed
Revision history for this message
mangtronix (mang) wrote :

I have this staged assigning pages with duplicate assertions the funky page numbers "{assertion}n{index}"

E.g. here are the new URLs for the two pages marked "5" in the book above:
http://www-mang.archive.org/stream/librariesoffutur00lickuoft#page/5n26/mode/1up
http://www-mang.archive.org/stream/librariesoffutur00lickuoft#page/5n8/mode/1up

If there are duplicate assertions I wonder if we should still support specifying just "page/5" and going to the LAST page with that assertion (least likely to be the introductory section)

Changed in gnubook:
status: Confirmed → In Progress
mangtronix (mang)
Changed in gnubook:
milestone: 0.9.8 → 0.9.9
mangtronix (mang)
Changed in gnubook:
milestone: 0.9.9 → 0.9.10
Revision history for this message
mangtronix (mang) wrote :

I changed it so that there can only be a single page with a given page number assertion. The last page with a given assertion retains the assertion. For example if there are three pages marked "5" the last page will keep the "5" assertion. The other pages will show up as "n{indexnumber}".

mangtronix (mang)
Changed in gnubook:
status: In Progress → Triaged
mangtronix (mang)
tags: added: needs-qa
Revision history for this message
mangtronix (mang) wrote :

Bonnie please test that only the *last* page with a given page number assertion X shows up as "Page X" in the URL and user interface. The other pages marked with that page number should show up as "Page n{index}".

e.g. in this book both the page printed with 'v' and '5' have the page 5 assertion. The last one should show up as "Page 5" and all others as "Page n{index}"
http://www-mang.archive.org/stream/librariesoffutur00lickuoft#page/n8/mode/1up
http://www-mang.archive.org/stream/librariesoffutur00lickuoft#page/5/mode/1up

Entering the page number in the URL should take you to the *last* page with that number.

Please let me know if you need more info!

Changed in gnubook:
assignee: mangtronix (mang) → Bonnie Real (bonnie-archive)
Revision history for this message
Bonnie Real (bonnie-archive) wrote :

Looks correct. I didn't come across *too* many examples, but I'll keep paying attention to it as I go along ...

tags: added: qa-verified
removed: needs-qa
Changed in gnubook:
assignee: Bonnie Real (bonnie-archive) → mangtronix (mang)
mangtronix (mang)
Changed in gnubook:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.