BlueBream

Incorrectly processing "If-Modified-Since" request header in zope.app.file

Bug #537263 reported by Kirill Kuzminykh on 2010-03-11

This bug affects 1 person

	Status	Importance	Assigned to
BlueBream	New	Undecided	Unassigned
Zope 3	Won't Fix	Undecided	Unassigned
zope.app.file	New	Undecided	Unassigned

Bug Description

In function zope.app.file.browser.file.FileView.show() (and z3c.blobfile.browser.file.FileView.show()) file modification date and date from Request Header "If-Modified-Since" are incorrectly compared.
Value of file modification date calculate as:
>> lmt = zope.datetime.time(modified.isoformat())
type(lmt) == float

Value of date from Request Header "If-Modified-Since" calculate as:
>> mod_since = long(zope.datetime.time(header))
type(mod_since) == long

As a result - lmt almost always is more than mod_since on some milliseconds. For example:
lmt = 1243412922.51
mod_since = 1243412922

Doctest for zope.app.file.browser.file.FileView.show() incorect tests "If-Modified-Since" request header, therefore errors was not.

I correct tests and code "zope.app.file.browser.file.FileView.show" method.

Revision history for this message

Kirill Kuzminykh (cykooz) wrote on 2010-03-11:

Patch for "zope/app/file/browser/file.py" Edit (1.9 KiB, text/plain)

Baiju Muthukadan (baijum) on 2010-03-12

affects:

bluebream → zope3

Revision history for this message

Tres Seaver (tseaver) wrote on 2010-04-14:

This bug should be tracked against the zope.app.file package, which is now released separately:

http://pypi.python.org/pypi/zope.app.file

There is (currently) no Launchpad project for that package.

Changed in zope3:
status:	New → Won't Fix

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Patches

Patch for "zope/app/file/browser/file.py" Edit

Add patch

Remote bug watches

Bug watches keep track of this bug in other bug trackers.