Blazar

Misuse of assert statements

Bug #1989267 reported by Takashi Natsume
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Blazar
Fix Released
Low
Takashi Natsume

Bug Description

There are some misuse of assert statements in the master (commit 8986cb8ad071474f6361b06ceeb631605afda31f).
'called_once_with' should be 'assert_called_once_with'.
'called_once' should be 'assert_called_once_with'.

blazar/tests/api/v1/test_utils.py
Line 47, 51, 55, 59

        self.rest._mroute.called_once_with(...

blazar/tests/notification/test_notifier.py
Line 72, 73

        self.fake_transport.called_once
        self.fake_notifier.called_once_with(self.fake_transport,

Takashi Natsume (natsume-takashi)
Changed in blazar:
assignee: nobody → Takashi Natsume (natsume-takashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to blazar (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/blazar/+/856908

Changed in blazar:
status: New → In Progress
Pierre Riteau (priteau)
Changed in blazar:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to blazar (master)

Reviewed: https://review.opendev.org/c/openstack/blazar/+/856908
Committed: https://opendev.org/openstack/blazar/commit/40f2f5d285c5067cb96468c499b7c28c9b938773
Submitter: "Zuul (22348)"
Branch: master

commit 40f2f5d285c5067cb96468c499b7c28c9b938773
Author: Takashi Natsume <email address hidden>
Date: Sun Sep 11 11:32:39 2022 +0900

    Fix misuse of assert statements

    Replace 'called_once_with' with 'assert_called_once_with'.
    Replace 'called_once' with 'assert_called_once_with'.

    Change-Id: I1d3c444c3e01b862a1a2571cf13d054dfd2fb463
    Closes-Bug: 1989267
    Signed-off-by: Takashi Natsume <email address hidden>

Changed in blazar:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/blazar 10.0.0.0rc1

This issue was fixed in the openstack/blazar 10.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.