Ussuri unit test failures

With py36 and latest neutron and neutron-lib I got a different error:
=========================
Failures during discovery
=========================
--- import errors ---
Failed to import test module: networking_bgpvpn.tests.unit.services.bagpipe.test_bagpipe
Traceback (most recent call last):
  File "/usr/lib/python3.6/unittest/loader.py", line 428, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/lib/python3.6/unittest/loader.py", line 369, in _get_module_from_name
    __import__(name)
  File "/home/lajoskatona/networking-bgpvpn/networking_bgpvpn/tests/unit/services/bagpipe/test_bagpipe.py", line 35, in <module>
    from networking_bgpvpn.neutron.services.service_drivers.bagpipe import bagpipe
  File "/home/lajoskatona/networking-bgpvpn/networking_bgpvpn/neutron/services/service_drivers/bagpipe/bagpipe.py", line 37, in <module>
    from networking_bgpvpn.neutron.services.service_drivers.bagpipe \
  File "/home/lajoskatona/networking-bgpvpn/networking_bgpvpn/neutron/services/service_drivers/bagpipe/bagpipe_v2.py", line 31, in <module>
    from networking_bagpipe.objects import bgpvpn as bgpvpn_objects
  File "/home/lajoskatona/networking-bgpvpn/.tox/py36/lib/python3.6/site-packages/networking_bagpipe/objects/bgpvpn.py", line 22, in <module>
    from neutron.objects import common_types
ImportError: cannot import name 'common_types'

So something is in the air.... I check it

If I fetch latest networking-bgpvpn and use latest neutron, neutron-lib and networking-bagpipe I have no issues with unittests on py36 & py37 at least.

Hi Lajos, this must be something on my end then. I have all the latest of those but must be something else that's different. Feel free to close and thanks for taking a look.

Hi, I double checked to be sure, but for me with latest neutron, neutron-lib and networking-bagpipe unittests passed.
If you see similar things don't hesitate :-)

Ok so the problem is that when we run unit tests in the ubuntu package they end up attempting to access /etc/neutron/networking_bgpvpn.conf but fail with permission denied (as can be seen in the test failure posted to this bug). The failure makes sense because we've tightened up access to during the ussuri release and the builds run under a non-root build user (not neutron or root). Do you know by any chance if there's a way to keep these tests from attempting to access /etc/neutron? Maybe there is a mock missing?

This part seems suspicious:
https://opendev.org/openstack/networking-bgpvpn/src/commit/d6a93f62337ffd4db88337b627008c6d9a7d276e/networking_bgpvpn/neutron/services/plugin.py#L54-L71

I check that later.
The strange is that if I run locally the tests I have no /etc/neutron/.... folder/files.

Yes! I also noticed when run with tox that there doesn't appear to be any /etc/neutron to access. Maybe add_provider_configuration can be mocked out.

Fix proposed to branch: master
Review: https://review.opendev.org/722308

Reviewed: https://review.opendev.org/722308
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=b5d51d0575208ddd161b94f2f3d5168407839859
Submitter: Zuul
Branch: master

commit b5d51d0575208ddd161b94f2f3d5168407839859
Author: Corey Bryant <email address hidden>
Date: Thu Apr 23 14:40:37 2020 -0400

    mock out ProviderConfiguration.__init__

    In some environments unit tests fails due to tests attempting to
    access /etc/neutron/ and not having permission to do so. Let's
    mock out add_provider_configuration to avoid this behaviour in
    unit test environment.

    Change-Id: If385c26e4a6bd9eca5bd873df4d25a2d888dd9a9
    Closes-Bug: #1872514