BeatBox

Beatbox use too often the disk

Bug #926709 reported by Corentin Noël
34
This bug affects 7 people
Affects Status Importance Assigned to Milestone
BeatBox
Fix Released
High
Victor Martinez
BeatBox 1.0

Bug Description

When I listen to a music, I can hear my disk used every second. This doen't happened when I use rythmbox.

Are you using files with read+write options ?

Tags: disk gtk listen

Related branches

lp://staging/~victored/beat-box/view-restructuring
Victor Martinez (community): Approve
Diff: 8950 lines (+4129/-2830)
39 files modified
core/Settings.vala (+130/-11)
schemas/org.elementary.beatbox.gschema.xml (+31/-0)
src/CMakeLists.txt (+2/-2)
src/DataBase/DataBaseUpdater.vala (+2/-3)
src/Devices/CDRomDevice.vala (+3/-2)
src/FileOperator.vala (+4/-3)
src/Icons.vala (+4/-5)
src/LibraryManager.vala (+32/-35)
src/LibraryWindow.vala (+473/-463)
src/Objects/Media.vala (+4/-1)
src/Objects/Playlist.vala (+30/-5)
src/Objects/SmartPlaylist.vala (+14/-1)
src/Store/Widgets/StoreView.vala (+4/-4)
src/Views/AlbumView/AlbumIconView-clutter.vala.BACKUP (+0/-720)
src/Views/AlbumView/AlbumIconView.vala (+61/-71)
src/Views/AlbumView/AlbumIconViewClutter.vala (+736/-0)
src/Views/AlbumView/AlbumListView.vala (+8/-6)
src/Views/ContentView.vala (+4/-8)
src/Views/DeviceSummaryWidget.vala (+2/-0)
src/Views/DeviceView.vala (+2/-3)
src/Views/DeviceViewWrapper.vala (+9/-5)
src/Views/ListView/BaseListModel.vala (+5/-2)
src/Views/ListView/BaseListView.vala (+38/-66)
src/Views/ListView/MillerColumns/MillerColumn.vala (+719/-0)
src/Views/ListView/MillerColumns/MillerModel.vala (+376/-0)
src/Views/ListView/MusicTreeModel.vala (+3/-2)
src/Views/ListView/MusicTreeView.vala (+25/-26)
src/Views/ListView/PodcastListView.vala (+14/-22)
src/Views/ListView/PodcastTreeModel.vala (+4/-2)
src/Views/ListView/RadioListView.vala (+10/-17)
src/Views/ListView/RadioTreeModel.vala (+4/-2)
src/Views/ListView/SimilarPane.vala (+88/-6)
src/Views/ViewWrapper.vala (+1056/-535)
src/Widgets/InfoPanel.vala (+4/-3)
src/Widgets/MillerColumns/MillerColumn.vala (+0/-223)
src/Widgets/MillerColumns/MillerModel.vala (+0/-274)
src/Widgets/SideBar.vala (+3/-3)
src/Widgets/SideTreeView.vala (+212/-292)
src/Widgets/WarningLabel.vala (+13/-7)
Victor Martinez (community): Needs Resubmitting
Diff: 21684 lines (+7534/-10649)
92 files modified
CMakeLists.txt (+71/-2)
INSTALL (+2/-1)
core/CMakeLists.txt (+23/-0)
core/EqualizerPreset.vala (+61/-0)
core/LibraryWindowInterface.vala (+27/-0)
core/PluginManager.vala (+161/-0)
core/Settings.vala (+632/-0)
images/CMakeLists.txt (+5/-1)
images/icons/16x16/actions/pane-hide-symbolic.svg (+60/-0)
images/icons/16x16/actions/pane-show-symbolic.svg (+56/-0)
images/icons/16x16/mimetypes/internet-radio.svg (+325/-569)
images/icons/16x16/mimetypes/playlist.svg (+85/-125)
images/icons/22x22/actions/document-open-recent.svg (+0/-238)
plugins/CMakeLists.txt (+1/-0)
plugins/podcasts/CMakeLists.txt (+30/-0)
plugins/podcasts/Podcasts.vala (+17/-0)
plugins/podcasts/podcasts.plugin (+10/-0)
po/beatbox.pot (+505/-306)
schemas/CMakeLists.txt (+1/-1)
schemas/org.elementary.beatbox.gschema.xml (+179/-0)
schemas/org.gnome.beatbox.gschema.xml (+0/-150)
src/BeatBox.vala (+17/-7)
src/CMakeLists.txt (+38/-111)
src/DataBase/DataBaseUpdater.vala (+15/-3)
src/Devices/CDRomDevice.vala (+3/-3)
src/Dialogs/AddPodcastWindow.vala (+21/-18)
src/Dialogs/EqualizerWindow.vala (+1/-1)
src/Dialogs/PlaylistNameWindow.vala (+21/-12)
src/Dialogs/RemoveFilesDialog.vala (+1/-1)
src/Dialogs/RemoveFromLibraryDialog.vala (+0/-148)
src/Dialogs/SetMusicFolderConfirmation.vala (+2/-2)
src/FileOperator.vala (+58/-8)
src/GStreamer/Pipeline.vala (+0/-2)
src/GStreamer/Ripper.vala (+0/-25)
src/GStreamer/Streamer.vala (+1/-1)
src/Icons.vala (+73/-70)
src/LibraryManager.vala (+246/-163)
src/LibraryWindow.vala (+401/-347)
src/Objects/EqualizerPreset.vala (+0/-61)
src/Objects/Icon.vala (+9/-0)
src/Objects/MPRIS.vala (+13/-13)
src/Objects/Media.vala (+2/-2)
src/Objects/MediaKeyListener.vala (+13/-9)
src/Objects/PodcastManager.vala (+3/-3)
src/Objects/SoundMenuIntegration.vala (+4/-4)
src/Settings.vala (+0/-508)
src/Store/Widgets/StoreView.vala (+4/-4)
src/Views/AlbumView/AlbumIconView-clutter.vala.BACKUP (+720/-0)
src/Views/AlbumView/AlbumIconView.vala (+95/-67)
src/Views/AlbumView/AlbumIconView_clutter.vala (+0/-720)
src/Views/AlbumView/AlbumListView.vala (+105/-61)
src/Views/AlbumView/AlbumViewModel.vala (+3/-2)
src/Views/CDRomViewWrapper.vala (+0/-231)
src/Views/CellDataFunctionHelper.vala (+2/-2)
src/Views/ContentView.vala (+5/-9)
src/Views/DeviceSummaryWidget.vala (+4/-6)
src/Views/DeviceView.vala (+2/-3)
src/Views/DeviceViewWrapper.vala (+9/-5)
src/Views/External/ExternalViewWrapper.vala (+0/-177)
src/Views/External/ListView/ExternalMusicTreeModel.vala (+0/-558)
src/Views/External/ListView/ExternalMusicTreeView.vala (+0/-1583)
src/Views/ListView/BaseListModel.vala (+403/-0)
src/Views/ListView/BaseListView.vala (+403/-0)
src/Views/ListView/MillerColumns/MillerColumn.vala (+611/-0)
src/Views/ListView/MillerColumns/MillerModel.vala (+309/-0)
src/Views/ListView/MusicTreeModel.vala (+8/-376)
src/Views/ListView/MusicTreeView.vala (+33/-434)
src/Views/ListView/PodcastListView.vala (+38/-451)
src/Views/ListView/PodcastTreeModel.vala (+8/-363)
src/Views/ListView/RadioListView.vala (+28/-415)
src/Views/ListView/RadioTreeModel.vala (+15/-371)
src/Views/ListView/SimilarPane.vala (+14/-56)
src/Views/ViewWrapper.vala (+878/-416)
src/Widgets/CoverArtImage.vala (+0/-58)
src/Widgets/DeviceBar.vala (+0/-91)
src/Widgets/InfoPanel.vala (+29/-36)
src/Widgets/MillerColumns/MillerColumn.vala (+0/-223)
src/Widgets/MillerColumns/MillerModel.vala (+0/-274)
src/Widgets/RatingWidget.vala (+4/-4)
src/Widgets/SideBar.vala (+3/-3)
src/Widgets/SideTreeView.vala (+132/-239)
src/Widgets/SimilarMediaView.vala (+1/-1)
src/Widgets/SimpleOptionChooser.vala (+27/-27)
src/Widgets/SpaceWidget.vala (+4/-4)
src/Widgets/StatusBar.vala (+164/-0)
src/Widgets/TopDisplay.vala (+237/-237)
src/Widgets/WarningLabel.vala (+5/-4)
src/Widgets/Welcome.vala (+0/-223)
src/config.h.cmake (+2/-0)
src/config.vapi (+1/-0)
vapi/CMakeLists.txt (+1/-0)
vapi/peas-gtk.vapi (+34/-0)
Revision history for this message
Victor Martinez (victored) wrote :

No, BeatBox doesn't read the song at every second. This is caused by the position updates. For some reason GStreamer accesses the hard disk while doing that, and it's annoying since we perform that operation two times per second.

Changed in beat-box:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Position updates? I thought that's just incrementing an internal variable and moving the slider... and writing that to disk on exit...

Revision history for this message
Victor Martinez (victored) wrote :

Every 0.5 seconds the streamer emits the current_position_update() signal. Only two objects have callbacks for that: the library window (for LastFM stuff) and the top display. I believe that the function that updates the toolbar scale is evil.

Changed in beat-box:
assignee: nobody → Victor Eduardo (victored)
Revision history for this message
Victor Martinez (victored) wrote :

I've made no progress in this bug so far.

In case other developer wants to take a look, the relevant file is TopDisplay.vala (located in src/Widgets).

This bug is provoked by updating the time labels in the toolbar (The ones displaying MM:SS). For some reason, every time we update them GTK+ accesses the disk (I wish I was wrong here). You can comment out lines 197 and 208 in that file to see what I mean.

Changed in beat-box:
assignee: Victor Eduardo (victored) → elementary Drive-by Contributors (elementary-driveby)
milestone: none → 1.0
Sergey "Shnatsel" Davidoff (shnatsel)
tags: added: gtk
Revision history for this message
Eduard Gotwig (gotwig) wrote :

It realy sucks, becouse I hear it ! :X (PC here)

Revision history for this message
Victor Martinez (victored) wrote :

Time to ask for help in GTK's mailing list? :)

Revision history for this message
Eduard Gotwig (gotwig) wrote :

Haven't you commited a fix for that, Victor? (btw, eduardo is a cool name :D)

Changed in beat-box:
status: Confirmed → In Progress
Revision history for this message
Victor Martinez (victored) wrote :

Thank you :)

And yes, the fix is on lp:~victored/beat-box/view-restructuring

(I'd like to get more testing on that branch too)

Victor Martinez (victored)
Changed in beat-box:
assignee: elementary Drive-by Contributors (elementary-driveby) → Victor Eduardo (victored)
Victor Martinez (victored)
Changed in beat-box:
status: In Progress → Fix Committed
Scott Ringwelski (sgringwe)
Changed in beat-box:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.