bash-completion

TAB completion on p4 gives _get_comp_words_by_ref(): `preprev': unknown argument

Bug #652104 reported by Doki on 2010-09-30

This bug affects 4 people

	Status	Importance	Assigned to
bash-completion	New	Undecided	Unassigned
bash-completion (Ubuntu)	Fix Released	Low	Unassigned
Maverick	Fix Released	Low	Angel Abad

Bug Description

Pressing TAB after p4 command results: bash: _get_comp_words_by_ref(): `preprev': unknown argument
printed. File completion works command completion does not.

It has been fixed in Debian (Issue: #312625 https://alioth.debian.org/tracker/?func=detail&atid=413095&aid=312625&group_id=100114) at:
http://git.debian.org/?p=bash-completion/bash-completion.git;a=commitdiff;h=5eead0ebeecf7d3212df3fea9cfe0fa88b6d0274

Tags:

Related branches

lp://staging/ubuntu/maverick-proposed/bash-completion

lp://staging/ubuntu/precise/bash-completion

Doki (lkishalmi) on 2010-09-30

affects:

bzr-bash-completion → bash-completion

Revision history for this message

Tim Wright (tim-wright-ideaworkslabs) wrote on 2010-10-13:

Does anyone know a workaround for this? I've applied the above fix to the file /etc/bash_completion.d/p4 however the bug is still present (updating that file makes no difference).

Revision history for this message

Doki (lkishalmi) wrote on 2010-10-13:

Working p4 bash-completion script for maverick Edit (1.5 KiB, text/plain)

Well, I've applied the patch manually om my /etc/bash_completion.d/p4 and since then the p4 code completion works.
I'm attaching my file.

Revision history for this message

Adam Guthrie (therigu) wrote on 2011-01-21:

I can confirm this on Maverick.

Changed in bash-completion (Ubuntu):
status:	New → Confirmed

Revision history for this message

Adam Guthrie (therigu) wrote on 2011-01-21:

Patch is good.

tags:

added: patch

Revision history for this message

Adam Guthrie (therigu) wrote on 2011-01-21:

p.patch Edit (1.2 KiB, text/plain)

Revision history for this message

Angel Abad (angelabad) wrote on 2011-02-02:

bash-completion_1.2-3ubuntu4.debdiff Edit (2.8 KiB, text/plain)

Debdiff with patch attached.

Changed in bash-completion (Ubuntu):
importance:	Undecided → Low

Revision history for this message

Bryce Harrington (bryce) wrote on 2011-02-04:

Looks good, upload sponsored for natty

Changed in bash-completion (Ubuntu):
status:	Confirmed → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2011-02-05:

This bug was fixed in the package bash-completion - 1:1.2-3ubuntu4

---------------
bash-completion (1:1.2-3ubuntu4) natty; urgency=low

* debian/patches/fix_p4_completion.patch:
- Fix p4 completion (LP: #652104)
-- Angel Abad <email address hidden> Wed, 02 Feb 2011 15:59:27 +0100

Changed in bash-completion (Ubuntu):
status:	Fix Committed → Fix Released

Revision history for this message

Kees Cook (kees) wrote on 2011-02-09:

Thanks for the maverick patch (from bug 690644) ! This looks good; I'll get it uploaded for testing in -proposed.

Changed in bash-completion (Ubuntu Maverick):
status:	New → Fix Committed
tags:	added: verification-needed

Revision history for this message

Kees Cook (kees) wrote on 2011-02-09:

#10

This has been uploaded to -proposed. Once it has built, please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Thank you in advance!

Revision history for this message

Martin Pitt (pitti) wrote on 2011-02-10: Please test proposed package

#11

Accepted bash-completion into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Revision history for this message

Doki (lkishalmi) wrote on 2011-02-10:

#12

I can confirm that the package in the proposed repository solves this problem!
Thank you very much!

Angel Abad (angelabad) on 2011-02-10

Changed in bash-completion (Ubuntu Maverick):
importance:	Undecided → Low
assignee:	nobody → Angel Abad (angelabad)

Martin Pitt (pitti) on 2011-02-10

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2011-02-23:

#13

This bug was fixed in the package bash-completion - 1:1.2-2ubuntu1.1

---------------
bash-completion (1:1.2-2ubuntu1.1) maverick-proposed; urgency=low

  * debian/patches/fix_typo_in_openssl_completion:
    - Fix typo in openssl completion (LP: #690644)
  * debian/patches/fix_p4_completion.patch:
    - Fix p4 completion (LP: #652104)
-- Angel Abad <email address hidden> Mon, 10 Jan 2011 18:07:59 +0100