Fix return/generation of the x-openstack-request-id header

Bug #1424221 reported by John Vrbanac
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Barbican
Fix Released
Medium
John Vrbanac

Bug Description

As a user, if you include the x-openstack-request-id header on a request it doesn't get returned back to the user on the response for proper request tracking. Instead it just logs a warning saying "Unable to retrieve request id from context". This functionality should return the request id provided by the user or generate one if the request id wasn't provided.

Changed in barbican:
assignee: nobody → John Vrbanac (john.vrbanac)
milestone: none → kilo-3
Changed in barbican:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to barbican (master)

Reviewed: https://review.openstack.org/158034
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=ce8d9fd39dac16b9b53a9c1192613d3b93ffd9ee
Submitter: Jenkins
Branch: master

commit ce8d9fd39dac16b9b53a9c1192613d3b93ffd9ee
Author: John Vrbanac <email address hidden>
Date: Fri Feb 20 23:46:12 2015 -0600

    Fixing unable to retrieve req id bug

    Properly returning the id if it was provided on the request. If not,
    generate an id in the format expected by openstack services
    and clients.

    Context:
    The original code in BaseContextMiddleware was copied from Glance
    at the beginning of the project, but it has never worked because
    we don't build our requests and responses like Glance does. As
    a result, the old code has been logging a "Unabled to retrieve request
    id from context" warning for every response. This change properly
    retrieves the id (if there), or generates one if needed.

    Closes-Bug: 1424221
    Change-Id: I7e22474775de3c3f33968144d098bedbfc462e7a

Changed in barbican:
status: In Progress → Fix Committed
Changed in barbican:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in barbican:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in barbican:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.