please re-enable aac decoding with internal libfaad

Doug McMahon <email address hidden> writes:

> Meanwhile gstreamer does provide aac decoding.

but only when installing additional packages from 'universe'. For xine,
the dependencies would need to be avaiable at build-time.

--
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4

Well I guess libxine1-ffmpeg can't be moved to universe like gstreamer0.10-plugins-bad ?
(i'd think that would then allow adding faad to the build depends

Doug McMahon <email address hidden> writes:

> Well I guess libxine1-ffmpeg can't be moved to universe like
> gstreamer0.10-plugins-bad ? (i'd think that would then allow adding
> faad to the build depends

No, bsides the source package is called 'xine-lib', and source
dependencies are declared for sourc packages.

moving xine-lib to univserse is not an option, as parts of xubuntu and
kubuntu depend on it AFAIUI. But feel free to start a discussion about
that on the ubuntu-devel mailing list.

--
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4

Again this is somewhat similar to the 'bug' in *buntu-restricted-extras, (karmic and lucid), where any explanation for the change is not forthcoming.

"the source package is called 'xine-lib'" - obviously I know that, the plug-in though is built in libxine-ffmpeg and so that's what is of concern here.

"...dependencies are declared for sourc packages." Fine, you've previously built faad decoding support into xine-libs without any dependency on libfaadX, I gather off of the internal faad in the xine-lib source.
( unless you were providing a more recent static faad, which while that's what I'd do , don't see that's part of repo builds

In any event the plug-in builds and works fine using the internal faad source in lucid, though a newer version might be preferred

so the question remains, - why aren't you building the plug-in as has been previously done? (8.10 - 9.10, and I guess 8.04

And if it's a question of the internal faad being to old then possibly the newer 1.1.17

while debian doesn't use the internal faad, we could *probably* do so for ubuntu. have you tested that for the lucid package and care to provide a patch if you can confirm that this works?

If I thought i was cofused as to the repo builds before, well....
>"while debian doesn't use the internal faad"

Taking a look at xine-lib on my karmic and earlier, where aac decoding is enabled by default, it seems you're using the internal faad. (the one included in the xine-lib source

If you're not build depending on libfaad, or supplying a static faad than the only other possibility is ffaac, which I don't see.

In any event it works fine, tested on a fresh lucid daily, nothing installed but lucid build-deps for libxine-ffmpeg (xine-lib), devscripts and gxine to test.

with the 'patched' libxine-ffmpeg installed

xine: found input plugin : file input plugin
xine: found demuxer plugin: Apple Quicktime (MOV) and MPEG-4 demux plugin

ldd -r /usr/lib/xine/plugins/1.26/xineplug_decode_faad.so
 linux-gate.so.1 => (0x00211000)
 libxine.so.1 => /usr/lib/libxine.so.1 (0x00b29000)
 libdl.so.2 => /lib/tls/i686/cmov/libdl.so.2 (0x00f66000)
 libfreetype.so.6 => /usr/lib/libfreetype.so.6 (0x002ab000)
 libz.so.1 => /lib/libz.so.1 (0x00dfd000)
 librt.so.1 => /lib/tls/i686/cmov/librt.so.1 (0x00115000)
 libresolv.so.2 => /lib/tls/i686/cmov/libresolv.so.2 (0x008b7000)
 libnsl.so.1 => /lib/tls/i686/cmov/libnsl.so.1 (0x0011e000)
 libm.so.6 => /lib/tls/i686/cmov/libm.so.6 (0x0082c000)
 libpthread.so.0 => /lib/tls/i686/cmov/libpthread.so.0 (0x00763000)
 libc.so.6 => /lib/tls/i686/cmov/libc.so.6 (0x003a2000)
 /lib/ld-linux.so.2 (0x00385000)

As far as a patch, it's just reversing what I believe to be an 'errant' comment

# debian/tmp/usr/lib/xine/plugins/*/xineplug_decode_faad.so

( you guys certainly don't need a patch from me, I hand edited, attached one anyway

Sorry, that shouldn't have been attached as such, basically just this

Index: xine-lib-1.1.16.3/debian/libxine1-ffmpeg.install
===================================================================
--- xine-lib-1.1.16.3/debian/libxine1-ffmpeg.install 2009-12-16 19:36:06.000000000 -0500
+++ xine-lib-1.1.16.3/debian/libxine1-ffmpeg.install 2009-12-16 19:41:10.000000000 -0500
@@ -1,5 +1,5 @@
 debian/tmp/usr/lib/xine/plugins/*/xineplug_decode_ff.so
-# debian/tmp/usr/lib/xine/plugins/*/xineplug_decode_faad.so
+debian/tmp/usr/lib/xine/plugins/*/xineplug_decode_faad.so
 debian/tmp/usr/lib/xine/plugins/*/xineplug_decode_mad.so
 debian/tmp/usr/lib/xine/plugins/*/xineplug_decode_mpeg2.so
 debian/tmp/usr/lib/xine/plugins/*/xineplug_decode_a52.so

This bug was fixed in the package xine-lib - 1.1.16.3-1ubuntu2

---------------
xine-lib (1.1.16.3-1ubuntu2) lucid; urgency=low

  * install the libfaad plugin. LP: #496010
 -- Reinhard Tartler <email address hidden> Thu, 17 Dec 2009 09:20:23 +0100