drive-harddisk-usb.svg and drive-removable-media-usb.svg should look different

Bug #445065 reported by Mantas Kriaučiūnas
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Humanity
Fix Released
Undecided
Unassigned
elementary Icons
Fix Released
Undecided
Danielle Foré
Baltix
New
Undecided
Unassigned
humanity-icon-theme (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Symlinks @drive-harddisk-usb.svg and @drive-removable-media-usb.svg points to the same gnome-dev-harddisk-usb.svg file in elementary-icons-2.2
These icons should be different, because drive-harddisk-usb.svg is for mounted partition (or device), while drive-removable-media-usb.svg is for unmounted, look at bug #253599 for more info about icon names of usb storage devices.

Related branches

Revision history for this message
Vish (vish) wrote :

In karmic:
drive-harddisk-usb > is used for external storage devices
drive-removable-media-usb > is used for pen drives

Changed in humanity:
status: New → Fix Committed
summary: drive-harddisk-usb.svg and drive-removable-media-usb.svg should look
- different - one is for mounted, second for unmounted
+ different
description: updated
Revision history for this message
Vish (vish) wrote :

Mantas Kriaučiūnas ,
As gvfs does not follow the fdo naming specs and the specs need to be updated.
The Humanity icons were designed for Karmic. If the icon naming can be done for jaunty and a separate package for Jaunty might be prepared if time permits.

Kindly do not change the bug descriptions midway . This changes the meaning of the bug completely!
I'm reverting the bug description. You could file a new bug instead.

Also on a side note, Kindly do not add other projects in the also affects for any humanity projects, We get mails regarding the projects we are not interested in.

-------------
Symlinks @drive-harddisk-usb.svg and @drive-removable-media-usb.svg points to the same gnome-dev-harddisk-usb.svg file in humanity-icon-theme 0.4.1ubuntu3 package and elementary-icons-2.2
These icons should be different, because drive-harddisk-usb.svg is for mounted partition (or device), while drive-removable-media-usb.svg is for unmounted, look at bug #253599 for more info about icon names of usb storage devices.

Humanity upstream developers renamed drive-removable-media-usb-pendrive.svg icons to drive-removable-media-usb.svg (see http://bazaar.launchpad.net/~elementaryart/humanity/Humanity/revision/397 ), but I think this is not good decision, because in Ubuntu 9.04 drive-removable-media-usb icon is for unmounted partitions of USB devices (all drive-removable-media* icons are used for unmounted partitions, for example drive-removable-media.svg icon is used for unmounted internal hard disk partitions).
Currently gnome-dev-harddisk-usb.svg icon looks like unmounted partition icon drive-removable-media.svg, but in Ubuntu 9.04 (Jaunty) this icon is used for mounted USB partition, and this misleads users :( I don't know how icons are used in Ubuntu Karmic, where gvfs hal monitor isn't used, I've find icon choosing code only in glib - http://git.gnome.org./cgit/glib/tree/gio/gunixmounts.c , but I'm not 100% sure if this is the code, which is used in Ubuntu 9.10 (Karmic) :(

For more info about icon usage look at http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html#devices and https://bugzilla.gnome.org/show_bug.cgi?id=506532#c6

description: updated
Revision history for this message
Vish (vish) wrote :

Oh , regarding the also affects, I meant in other bugs , where tangerine theme or some other themes were added to the also affects.

Changed in humanity-icon-theme (Ubuntu):
status: New → Confirmed
Revision history for this message
Vish (vish) wrote :

 Humanity_0.4.2.1

Changed in humanity:
status: Fix Committed → Fix Released
Vish (vish)
Changed in humanity-icon-theme (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Is this considered committed or released for elementary Icons?

Changed in elementaryicons:
status: New → Fix Committed
assignee: nobody → Daniel Fore (danrabbit)
Changed in elementaryicons:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.