Window management - When a semi-maximised a window is maximised and then restored, the window position jumps and window size changes so the the window title bar is sometimes hidden underneath the top bar
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Committed
|
Critical
|
John Lea | ||
Compiz |
Fix Released
|
High
|
Brandon Schaefer | ||
Unity Distro Priority |
Confirmed
|
Undecided
|
Unassigned | ||
compiz (Ubuntu) |
Fix Released
|
High
|
Brandon Schaefer |
Bug Description
Note: reverting bug to triarged because the fix is not complete. When tested the correct behavour of "the window should return to exactly the same state it had at the beginning of step 1." is not fulfilled.
-------
Window management - When a Semi-maximising a window is maximised by clicking on the window decorations and then returned to the semi-maximised state, the window position jumps so the the window title bar is hidden underneath the top bar.
One way reproduce the bug:
1. Take a restored window
2. Semi-maximise the window
3. Press CTRL + SUPER + UP ARROW to maximise the window
4. Click on the 'restore' window decoration to return the window to the restored state state.
What currently incorrectly happens:
- After performing step 3, the window returns to a weird state where it is restored, but in the size and shape of a semi-maximised window, and the position is also offset from what would be expected from a semi-maximised window. This is especially problematic because in some cases the window is positioned so that all of the window title bar is underneath the top bar, making it impossible for a user to move the window without knowing a keyboard shortcut.
See the attached screencast "window_
Desired behavour:
- On pressing the 'restore' window decoration in step 4 of the bug reproduction instructions, the window should return to exactly the same state it had at the beginning of step 1.
- When fixing this bug, also review and look at fixing bug https:/
-------
Another way to reproduce the bug:
1. Semi-maximise the Thunderbird main window
2. Press the 'restore' window decoration (button on the far right of the 3 button cluster)
What currently incorrectly happens:
- The window jumps up so that the window title bar in underneath the top bar
What should happen
- The window should return to it's previous 'restored' state.
Related branches
- Daniel van Vugt: Approve
- Alan Griffiths: Approve
- Sam Spilsbury: Pending requested
-
Diff: 2394 lines (+509/-779)19 files modifiedplugins/composite/src/window.cpp (+15/-35)
plugins/decor/src/decor.cpp (+66/-53)
plugins/decor/src/decor.h (+2/-3)
plugins/move/src/move.cpp (+2/-4)
plugins/opengl/src/paint.cpp (+11/-18)
plugins/opengl/src/privates.h (+7/-1)
plugins/opengl/src/window.cpp (+39/-17)
plugins/place/src/constrain-to-workarea/src/constrain-to-workarea.cpp (+4/-6)
plugins/place/src/place.cpp (+19/-24)
plugins/resize/src/resize.cpp (+1/-11)
plugins/resize/src/resize.h (+0/-2)
plugins/wobbly/src/wobbly.cpp (+5/-4)
src/event.cpp (+1/-1)
src/privatewindow.h (+7/-8)
src/screen.cpp (+4/-2)
src/window.cpp (+270/-543)
src/window/geometry/include/core/windowgeometry.h (+6/-0)
src/window/geometry/tests/window-geometry/src/test-window-geometry.cpp (+10/-0)
src/windowgeometry.cpp (+40/-47)
- Daniel van Vugt: Needs Fixing
- Sam Spilsbury: Pending requested
- Alan Griffiths: Pending requested
-
Diff: 2780 lines (+584/-844)21 files modifiedplugins/composite/src/window.cpp (+19/-39)
plugins/decor/src/decor.cpp (+80/-59)
plugins/decor/src/decor.h (+4/-3)
plugins/move/src/move.cpp (+10/-12)
plugins/opengl/src/paint.cpp (+11/-18)
plugins/opengl/src/privates.h (+7/-1)
plugins/opengl/src/window.cpp (+39/-17)
plugins/place/src/constrain-to-workarea/src/constrain-to-workarea.cpp (+4/-6)
plugins/place/src/place.cpp (+19/-24)
plugins/resize/src/resize.cpp (+8/-18)
plugins/resize/src/resize.h (+0/-2)
plugins/wobbly/src/wobbly.cpp (+37/-40)
plugins/wobbly/src/wobbly.h (+2/-0)
src/actions.cpp (+2/-2)
src/event.cpp (+1/-1)
src/privatewindow.h (+7/-8)
src/screen.cpp (+4/-2)
src/window.cpp (+274/-545)
src/window/geometry/include/core/windowgeometry.h (+6/-0)
src/window/geometry/tests/window-geometry/src/test-window-geometry.cpp (+10/-0)
src/windowgeometry.cpp (+40/-47)
- Daniel van Vugt: Needs Resubmitting
- Alan Griffiths: Needs Fixing
-
Diff: 1316 lines (+247/-559)9 files modifiedinclude/core/window.h (+2/-2)
plugins/composite/src/window.cpp (+16/-16)
plugins/decor/src/decor.cpp (+15/-15)
plugins/move/src/move.cpp (+1/-11)
plugins/opengl/src/window.cpp (+2/-2)
src/event.cpp (+2/-2)
src/privatewindow.h (+10/-12)
src/window.cpp (+195/-495)
src/windowgeometry.cpp (+4/-4)
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Sam Spilsbury: Needs Fixing
- MC Return: Approve
-
Diff: 87 lines (+15/-8)2 files modifiedsrc/privatewindow.h (+1/-0)
src/window.cpp (+14/-8)
- PS Jenkins bot (community): Approve (continuous-integration)
- Sam Spilsbury: Approve
- MC Return: Approve
- Sami Jaktholm (community): Approve
-
Diff: 26 lines (+16/-0)1 file modifiedplugins/grid/src/grid.cpp (+16/-0)
tags: | added: udp |
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
importance: | Undecided → Critical |
status: | New → Triaged |
Changed in unity: | |
milestone: | none → backlog |
status: | New → Confirmed |
Changed in unity (Ubuntu): | |
status: | New → Confirmed |
summary: |
- Window management - When a Semi-maximising a window is maximised by - clicking on the window decorations and then returned to the semi- - maximised state, the window position jumps so the the window title bar - is hidden underneath the top bar + Window management - When a Semi-maximising a window is maximised and + then restored, the window position jumps and window size changes so the + the window title bar is sometimes hidden underneath the top bar |
description: | updated |
Changed in unity (Ubuntu): | |
importance: | Undecided → Medium |
Changed in ayatana-design: | |
status: | Triaged → Fix Committed |
Changed in unity: | |
importance: | Undecided → High |
description: | updated |
Changed in unity (Ubuntu): | |
importance: | Medium → High |
summary: |
- Window management - When a Semi-maximising a window is maximised and + Window management - When a semi-maximised a window is maximised and then restored, the window position jumps and window size changes so the the window title bar is sometimes hidden underneath the top bar |
tags: | added: top5p |
Changed in ayatana-design: | |
importance: | Critical → High |
importance: | High → Critical |
Changed in unity: | |
assignee: | nobody → Sam Spilsbury (smspillaz) |
Changed in unity-distro-priority: | |
status: | New → Fix Committed |
tags: | added: rls-p-tracking |
tags: | removed: rls-p-tracking |
Changed in compiz-core: | |
status: | New → In Progress |
assignee: | nobody → Sam Spilsbury (smspillaz) |
importance: | Undecided → High |
milestone: | none → 0.9.7.8 |
Changed in unity: | |
milestone: | backlog → 5.12.0 |
affects: | unity (Ubuntu) → compiz (Ubuntu) |
Changed in unity: | |
milestone: | 5.12.0 → 5.14.0 |
Changed in compiz: | |
milestone: | none → 0.9.8.0 |
status: | New → Fix Committed |
importance: | Undecided → High |
assignee: | nobody → Sam Spilsbury (smspillaz) |
no longer affects: | compiz-core/0.9.7 |
no longer affects: | compiz-core/0.9.8 |
Changed in compiz-core: | |
milestone: | 0.9.8.0 → none |
no longer affects: | compiz-core |
Changed in unity: | |
status: | Confirmed → Triaged |
Changed in unity (Ubuntu): | |
status: | Confirmed → Triaged |
Changed in compiz (Ubuntu): | |
status: | Confirmed → Triaged |
Changed in unity (Ubuntu): | |
importance: | Undecided → High |
description: | updated |
Changed in unity: | |
milestone: | 5.14.0 → 5.16.0 |
Changed in compiz: | |
status: | Fix Committed → Fix Released |
Changed in unity: | |
milestone: | 5.16.0 → 5.18.0 |
Changed in unity: | |
milestone: | 5.18.0 → none |
status: | Triaged → Invalid |
Changed in unity (Ubuntu): | |
status: | New → Invalid |
Changed in unity (Ubuntu): | |
importance: | Undecided → High |
no longer affects: | unity |
no longer affects: | unity (Ubuntu) |
Changed in compiz: | |
milestone: | 0.9.8.0 → 0.9.10.0 |
assignee: | Sam Spilsbury (smspillaz) → Brandon Schaefer (brandontschaefer) |
Changed in compiz (Ubuntu): | |
assignee: | nobody → Brandon Schaefer (brandontschaefer) |
Changed in compiz: | |
status: | Triaged → In Progress |
Changed in compiz (Ubuntu): | |
status: | Triaged → In Progress |
Changed in compiz (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in compiz: | |
status: | Fix Committed → Fix Released |
tags: | added: rls-w-incoming |
I can't reproduce this anymore with newest compiz, please check it again.