Launcher - The Nautilus and USB drive icons in the Launcher should be valid drop targets for all types of files and folders
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ayatana Design |
Fix Committed
|
High
|
John Lea | ||
| Unity |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
| unity (Ubuntu) |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
Bug Description
The Nautilus and USB drive icons in the Launcher should be valid drop targets for all types of files and folders
When a user starts dragging a file or folder, Launcher icons that are valid drop targets are highlighted by means of all the other Launcher icons dimming. However HOME and USB drive launcher icons do not currently remain illuminated even though they should be valid drop targets for all files and folders.
Desired solution:
- HOME and USB drive icons (and any other icons that represent storage devices) in the Launcher should remain illuminated when a user starts performing a file or folder drag action.
- The exception to the above statement is when the drag originates from a Nautilus window. In this case the originating Launcher icon should not be highlighted, e.g. when dragging a file from a USB drive, the USB drive the file is being dragged from should not illuminate.
- Dropping a file or folder on to a HOME and USB drive icon should copy that file or folder to the directory that is currently in focus. For example, if no HOME window is currently open, dropping a file on to the HOME icon should copy that file into the /home/[User]/ directory. However if Nautilus has been opened by clicking on the HOME Launcher icon and is currently displaying the /Pictures/ directory, dropping the file on to the HOME launcher icon should copy the file to the /Pictures/ directory.
- If multiple Nautilus windows have been opened by clicking on a single Launcher entry (e.g. by middle clicking several times on the HOME icon), droping a file on to the Launcher entry (e.g. HOME icon) copies the file to the most recently focused of these windows.
- In line with the standard Launcher drag and drop behavour, if there multiple windows have been opened from a single storage icon (e.g. HOME), holding the file over the Launcher icon should trigger a spread. This enables the user to then choose which window they would like to copy the file into.
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Brandon Schaefer (community): Approve
- Andrea Azzarone (community): Needs Information
-
Diff: 695 lines (+166/-103)9 files modifiedlauncher/ApplicationLauncherIcon.cpp (+3/-13)
launcher/ApplicationLauncherIcon.h (+0/-1)
launcher/VolumeLauncherIcon.cpp (+40/-4)
launcher/VolumeLauncherIcon.h (+4/-1)
tests/test_mock_filemanager.h (+1/-0)
tests/test_volume_launcher_icon.cpp (+82/-84)
unity-shared/FileManager.h (+2/-0)
unity-shared/GnomeFileManager.cpp (+32/-0)
unity-shared/GnomeFileManager.h (+2/-0)
| tags: | added: onew udo |
| Changed in ayatana-design: | |
| assignee: | nobody → John Lea (johnlea) |
| importance: | Undecided → High |
| status: | New → Fix Committed |
| Changed in unity: | |
| assignee: | nobody → Jason Smith (jassmith) |
| Changed in unity (Ubuntu): | |
| assignee: | nobody → Jason Smith (jassmith) |
| Changed in unity: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| Changed in unity (Ubuntu): | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| Changed in ayatana-design: | |
| status: | Fix Committed → Fix Released |
| tags: | added: udp |
| Changed in unity: | |
| milestone: | none → backlog |
| Changed in ayatana-design: | |
| status: | Fix Released → Fix Committed |
| Changed in unity: | |
| assignee: | Jason Smith (jassmith) → nobody |
| Changed in unity (Ubuntu): | |
| assignee: | Jason Smith (jassmith) → nobody |
| Changed in unity: | |
| assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
| Changed in unity (Ubuntu): | |
| assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
| Changed in unity: | |
| milestone: | backlog → 7.0.0 |
| Changed in unity: | |
| milestone: | 7.0.0 → 7.0.1 |
| Changed in unity: | |
| milestone: | 7.0.1 → 7.1.0 |
| Changed in unity: | |
| milestone: | 7.1.0 → 7.1.1 |
| Changed in unity: | |
| milestone: | 7.1.1 → 7.2.0 |
| Changed in unity: | |
| milestone: | 7.2.0 → 7.1.2 |
| status: | Triaged → In Progress |
| Changed in unity (Ubuntu): | |
| status: | Triaged → In Progress |
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in unity: | |
| status: | In Progress → Fix Committed |
| Changed in unity: | |
| milestone: | 7.1.2 → 7.1.1 |
| status: | Fix Committed → Fix Released |
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in unity (Ubuntu): | |
| status: | In Progress → Fix Released |
| tags: | added: rls-w-incoming |
Fix committed into lp:unity at revision None, scheduled for release in unity, milestone 7.1.1