Timezones not in time order

Subtask of bug #823181.

James, just to make sure I'm understanding this ticket correctly -- you're referring to the order of the times shown inbetween "Add Event..." and "Time & Date Settings..." in your screenshot, is that correct?

Same pb here (Precise), I think James was indeed referring to the order of the times shown inbetween "Add Event..." and "Time & Date Settings...".

It is:
- UTC 19:54
- Paris 21:54
- London 20:54

and it should be (and it used to be):
- UTC 19:54
- London 20:54
- Paris 21:54

Good stuff, Charles!

The design is not Incomplete; it has been specified since July 2010. "The order of locations in the menu should always match the order of locations in the window ... Clicking the “Location” header cell should sort the locations alphabetically, and clicking it again should sort them reverse alphabetically. Clicking the “Time” header cell should sort the locations earliest first, and clicking it again should sort them latest first." <https://wiki.ubuntu.com/TimeAndDate#locations>

The first part works in indicator-datetime 0.3.90-0ubuntu1: the menu updates live to match whatever order you specify in the window. If the "/* sort the list by timezone offset */" code changes this, that's a regression. Sorting by timezone offset should happen only if you click the "Time" column header, which in 0.3.90-0ubuntu1 does nothing.

mpt: I think it was marked as incomplete this ticket is about sorting the locations inbetween "Add Event..." and "Time & Date Settings..." in the menu, not about the Locations window.

The design currently says the locations should be listed, but doesn't address order: "Whenever “Time in other locations” is checked, the times in the chosen locations should be present in the menu. Activating any of these items should change the time zone to that location (with the authorization dialog acting as a confirmation step). " <https://wiki.ubuntu.com/TimeAndDate#The_menu>

Ah, I read through comment #6 too quickly.

Following our discussion Tuesday and yesterday, I've updated the specification to include "Sort by Name" and "Sort by Time" buttons in the "Locations" window. <https://wiki.ubuntu.com/TimeAndDate?action=diff&rev2=41&rev1=40>

Re-opening as per the refined spec

MPT, re comment #6, I meant to express that we'd need some input from Design - seems we have everything needed. Charles will attach a screenshot for design review.

Charles, that looks pretty good, thank you. Just two minor glitches:
(1) There should be as much padding to the left of the "+" button as there is above and below it.
(2) When sorted by time, Budapest should go before Paris, because they're the same time but Budapest is alphabetically earlier. I've added this to the spec. <https://wiki.ubuntu.com/TimeAndDate?action=diff&rev2=47&rev1=46>

Tested with indicator-datetime 12.10.2-0ubuntu1 in Ubuntu Q. This all seems to be working now.