Ayatana Design

[FFe] Add 'legal notice' to "System Settings/Details" panel

Bug #1130158 reported by John Lea on 2013-02-19

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Ayatana Design	Fix Released	High	John Lea
	gnome-control-center (Ubuntu)	Fix Released	Low	Sebastien Bacher

Bug Description

Change request:

1) Add "Legal notice" to the "System Settings/Details" left hand nav, so that the navigation reads as follows

Overview
Default Applications
Removable Media
Graphics
Legal Notice

2) Clicking on "Legal Notice" should then display the contents of the attached "searching the dash legal notice.html" file in the body area of the "System Settings/Details" panel

Tags:

Related branches

lp://staging/ubuntu/raring-proposed/gnome-control-center

lp://staging/~ubuntu-desktop/gnome-control-center/unity

Revision history for this message

John Lea (johnlea) wrote on 2013-02-19:

searching the dash legal notice.html Edit (6.1 KiB, text/html)

Changed in ayatana-design:
importance:	Undecided → High
status:	New → Fix Committed
assignee:	nobody → John Lea (johnlea)

John Lea (johnlea) on 2013-02-21

Changed in gnome-control-center (Ubuntu):
assignee:	nobody → Didier Roche (didrocks)
status:	New → Triaged
importance:	Undecided → Medium
tags:	added: udp

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2013-02-21:

Seb agreed to work on that and adding to his *huge* backlog :p

Changed in gnome-control-center (Ubuntu):
assignee:	Didier Roche (didrocks) → Sebastien Bacher (seb128)

Revision history for this message

Sebastien Bacher (seb128) wrote on 2013-03-11:

some hackish attempt to this change Edit (7.5 KiB, text/plain)

Revision history for this message

Sebastien Bacher (seb128) wrote on 2013-03-11:

I'm attaching a working patch, the GtkLinkButton widget are not aligned with the text and look weird and the file needs to be installed on disk for that to work.

Not sure I like this approch though but the other option would be to use webkit which I'm not sure I like better... GTK has simply no good way to render a simple html file like that :-(

Ubuntu Foundations Team Bug Bot (crichton) on 2013-03-11

tags:

added: patch

Revision history for this message

Sebastien Bacher (seb128) wrote on 2013-03-12:

smaller patch using webkitgtk Edit (3.2 KiB, text/plain)

ok, much easier with webkitgtk so let's us that

We are after FFe so asking for an exception there as well, that's a small patch and impact only unity sessions (the code does nothing out of Unity)

summary:	- Add 'legal notice' to "System Settings/Details" panel + [FFe] Add 'legal notice' to "System Settings/Details" panel
Changed in gnome-control-center (Ubuntu):
status:	Triaged → In Progress
importance:	Medium → Low

Revision history for this message

Stefano Rivera (stefanor) wrote on 2013-03-13:

I'm OK with this. Britney block added for the duration of the Beta 1 freeze.

Sebastien Bacher (seb128) on 2013-03-15

Changed in gnome-control-center (Ubuntu):
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-03-15:

This bug was fixed in the package gnome-control-center - 1:3.6.3-0ubuntu15

---------------
gnome-control-center (1:3.6.3-0ubuntu15) raring; urgency=low

  * debian/control.in:
    - Build-Depends on libwebkitgtk-3.0-dev
  * debian/patches/unity_notice_info.patch:
    - display "Legal Notice" in the infos dialog (lp: #1130158)
  * debian/searchingthedashlegalnotice.html,
    debian/gnome-control-center-data.install:
    - copy notice text from unity, will be updated later
-- Sebastien Bacher <email address hidden> Fri, 15 Mar 2013 18:40:53 +0100