Ayatana Design

[regression] Dash - When a drag and drop action from the Dash is abandoned by dropping the item back into the Dash, all the Launcher icons 'flicker' as they suddenly loose their tinting for a brief moment

Bug #1064514 reported by John Lea
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Fix Committed
High
John Lea
Unity
Fix Released
High
Marco Trevisan (Treviño)
Unity 7.2.0
unity (Ubuntu)
Fix Released
High
Marco Trevisan (Treviño)

Bug Description

When a drag and drop action from the Dash is abandoned by dropping the item back into the Dash, all the Launcher icons suddenly become illuminated

To reproduce:

1. To reproduce this bug you must be using duel monitors, set up to extend the desktop (e.g. NOT mirror)
2. Open the Dash on one of the monitors, and start to drag an item
3. Drop the item back into the Dash to abandon the action.

Current incorrect behaviour in 12.10: either:
a) All the Launcher icons suddenly loose their tinting for a brief moment (e.g. all the Launcher icons flicker)
b) After the drop action has been perfomred, all the Launcher icons loose their tinting

A screencast of this bug is attached, see Launcher_flicker.ogv

Note this screencase was made on the 10th Oct 2012, with a fully up to date vanilla install of Quantal

Correct desired behaviour as currently implemented in 12.04: When the drag and drop action is abandoned, the valid drop receptacles return to the tinted state. The Launcher icons which were not valid drop receptacles do not change of flicker in any way, they remain in the tinted state.

See original description
Tags: dashm dashs udp

Related branches

lp://staging/~3v1n0/unity/multi-monitor-icon-quirks
PS Jenkins bot (community): Approve (continuous-integration)
Brandon Schaefer (community): Approve
Diff: 3659 lines (+1081/-576)
50 files modified
launcher/AbstractLauncherIcon.h (+9/-9)
launcher/ApplicationLauncherIcon.cpp (+12/-10)
launcher/ApplicationLauncherIcon.h (+1/-1)
launcher/BFBLauncherIcon.cpp (+2/-4)
launcher/DesktopLauncherIcon.cpp (+0/-1)
launcher/ExpoLauncherIcon.cpp (+0/-2)
launcher/HudLauncherIcon.cpp (+5/-11)
launcher/Launcher.cpp (+152/-153)
launcher/Launcher.h (+1/-3)
launcher/LauncherController.cpp (+11/-13)
launcher/LauncherControllerPrivate.h (+1/-2)
launcher/LauncherIcon.cpp (+107/-80)
launcher/LauncherIcon.h (+28/-31)
launcher/MockLauncherIcon.h (+55/-21)
launcher/SingleMonitorLauncherIcon.cpp (+4/-6)
launcher/SingleMonitorLauncherIcon.h (+4/-5)
launcher/SoftwareCenterLauncherIcon.cpp (+5/-7)
launcher/SpacerLauncherIcon.cpp (+0/-1)
launcher/StandaloneLauncher.cpp (+6/-1)
launcher/XdndCollectionWindow.h (+1/-0)
launcher/XdndCollectionWindowImp.cpp (+8/-2)
launcher/XdndCollectionWindowImp.h (+1/-0)
launcher/XdndManager.h (+4/-2)
launcher/XdndManagerImp.cpp (+20/-12)
launcher/XdndManagerImp.h (+5/-2)
plugins/unityshell/src/unityshell.cpp (+1/-1)
plugins/unityshell/src/unityshell.h (+2/-1)
tests/mock-application.h (+4/-2)
tests/test_application_launcher_icon.cpp (+2/-10)
tests/test_bamf_application.cpp (+3/-2)
tests/test_expo_launcher_icon.cpp (+2/-11)
tests/test_launcher.cpp (+30/-40)
tests/test_launcher_controller.cpp (+125/-19)
tests/test_launcher_hover_machine.cpp (+3/-3)
tests/test_launcher_icon.cpp (+225/-12)
tests/test_layout_system.cpp (+12/-10)
tests/test_panel_menu_view.cpp (+2/-6)
tests/test_panel_view.cpp (+2/-4)
tests/test_shortcut_modeller_compiz.cpp (+3/-4)
tests/test_software_center_launcher_icon.cpp (+14/-4)
tests/test_standalone_wm.h (+60/-0)
tests/test_switcher_controller.h (+3/-2)
tests/test_switcher_controller_class.cpp (+7/-4)
tests/test_switcher_view.cpp (+2/-6)
tests/test_window_buttons.cpp (+2/-6)
tests/test_xdnd_manager_imp.cpp (+40/-29)
unity-shared/StandaloneWindowManager.cpp (+38/-15)
unity-shared/StandaloneWindowManager.h (+3/-0)
unity-shared/TimeUtil.h (+47/-4)
unity-standalone/StandaloneUnity.cpp (+7/-2)
John Lea (johnlea)
Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
importance: Undecided → High
summary: [regression] Dash - When a drag and drop action from the Dash is
abandoned by dropping the item back into the Dash, all the Launcher
- icons suddenly loose all their tinting for a brief moment
+ icons suddenly loose their tinting for a brief moment
summary: [regression] Dash - When a drag and drop action from the Dash is
abandoned by dropping the item back into the Dash, all the Launcher
- icons suddenly loose their tinting for a brief moment
+ icons 'flicker' as they suddenly loose their tinting for a brief moment
Changed in unity:
importance: Undecided → High
Changed in unity (Ubuntu):
importance: Undecided → High
Changed in ayatana-design:
status: New → Triaged
Changed in unity:
status: New → Triaged
Changed in unity (Ubuntu):
status: New → Triaged
tags: added: dashm dashs udp
Changed in ayatana-design:
status: Triaged → Fix Committed
Revision history for this message
Andrea Azzarone (azzar1) wrote :

Can you make a video of the bug. I cannot reproduce here.

Changed in unity:
status: Triaged → Incomplete
Changed in unity (Ubuntu):
status: Triaged → Incomplete
Revision history for this message
John Lea (johnlea) wrote :
description: updated
Changed in unity:
status: Incomplete → Triaged
Changed in unity (Ubuntu):
status: Incomplete → Triaged
Revision history for this message
John Lea (johnlea) wrote :

@andyrock; I've attached a screencast. When making the screencast I discovered that this bug only occurs on multi-monitor systems, I have updated the bug description accordingly.

Nick Dedekind (nick-dedekind)
Changed in unity:
assignee: nobody → Nick Dedekind (nick-dedekind)
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

So, this happens because the different launchers all share the same launcher model (ie the icon backend), which is where the saturation state exists; but the "overlay enabled" & hover states exists on a per launcher basis.

1) When the use cancels a drag, we reset the saturation status to the intended value.
2) However, we do this in both launchers, one of which "overlay enabled" is false, causing the icons to saturate.
3) Which monitor you have the dash open on will give different results. First will leave the icons saturated, second will flicker them as they briefly turn saturated, then desaturated.

Question: Do we not wan the overlay on all monitors if the dash/hud is open?

Either we need to have the hover/overlay state shared between the model, or we need to have icon states (quirks) per launcher, or there needs to be some hacky-jiggery-pokery for checking which monitor we're operating on.

Marco Trevisan (Treviño) (3v1n0)
Changed in unity (Ubuntu):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in unity:
milestone: none → 7.2.0
assignee: Nick Dedekind (nick-dedekind) → Marco Trevisan (Treviño) (3v1n0)
status: Triaged → Fix Committed
Changed in unity (Ubuntu):
status: Triaged → Fix Committed
Marco Trevisan (Treviño) (3v1n0)
Changed in unity (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Stephen M. Webb (bregma) wrote :

Fix Released in Unity Unity 7.2.0.

Changed in unity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.