Launcher - clicking "unlock from Launcher" on the quicklist of a storage device, removes the storage device from the Launcher even if it's window is open
Bug #1063823 reported by
John Lea
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ayatana Design |
Fix Committed
|
Medium
|
John Lea | ||
| unity (Ubuntu) |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
| Xenial |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
Bug Description
Currently clicking "unlock from Launcher" on the quicklist of a storage device (e.g. USB key), removes the storage device from the Launcher even if it's window is open. This behavour is incorrect.
The correct behavour for the "unlock from Launcher" function is only to remove the icon from the Launcher when the application is not running.
-------
Desired solution:
- If any directory from the storage device is currently open in Nautilus, clicking "unlock from Launcher" should not remove the storage device icon from the Launcher until no directories from the storage device are being viewed in Nautilus.
Related branches
lp://staging/~3v1n0/unity/launcher-filemanager-integration
- Andrea Azzarone (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 5139 lines (+2020/-1214)47 files modifiedUnityCore/DesktopUtilities.cpp (+5/-0)
UnityCore/DesktopUtilities.h (+1/-0)
UnityCore/GLibDBusProxy.cpp (+3/-3)
debian/control (+1/-0)
launcher/AbstractLauncherIcon.h (+11/-7)
launcher/ApplicationLauncherIcon.cpp (+118/-685)
launcher/ApplicationLauncherIcon.h (+51/-94)
launcher/CMakeLists.txt (+3/-0)
launcher/DesktopLauncherIcon.cpp (+5/-0)
launcher/DesktopLauncherIcon.h (+1/-0)
launcher/DeviceLauncherSection.h (+4/-0)
launcher/FileManagerLauncherIcon.cpp (+128/-0)
launcher/FileManagerLauncherIcon.h (+52/-0)
launcher/Launcher.cpp (+2/-9)
launcher/LauncherController.cpp (+24/-7)
launcher/LauncherControllerPrivate.h (+2/-1)
launcher/LauncherIcon.cpp (+12/-2)
launcher/LauncherIcon.h (+14/-10)
launcher/MockLauncherIcon.h (+38/-28)
launcher/SoftwareCenterLauncherIcon.cpp (+2/-1)
launcher/StorageLauncherIcon.cpp (+119/-0)
launcher/StorageLauncherIcon.h (+55/-0)
launcher/SwitcherController.cpp (+4/-7)
launcher/SwitcherModel.cpp (+2/-11)
launcher/SwitcherView.cpp (+1/-1)
launcher/TrashLauncherIcon.cpp (+49/-21)
launcher/TrashLauncherIcon.h (+5/-7)
launcher/VolumeLauncherIcon.cpp (+101/-63)
launcher/VolumeLauncherIcon.h (+7/-5)
launcher/WindowedLauncherIcon.cpp (+618/-0)
launcher/WindowedLauncherIcon.h (+100/-0)
tests/CMakeLists.txt (+1/-0)
tests/mock-application.h (+12/-2)
tests/test_application_launcher_icon.cpp (+15/-30)
tests/test_launcher_controller.cpp (+53/-48)
tests/test_mock_filemanager.h (+8/-5)
tests/test_software_center_launcher_icon.cpp (+3/-2)
tests/test_switcher_controller.h (+6/-16)
tests/test_switcher_controller_class.cpp (+9/-18)
tests/test_trash_launcher_icon.cpp (+72/-2)
tests/test_volume_launcher_icon.cpp (+169/-27)
unity-shared/ApplicationManager.h (+3/-0)
unity-shared/BamfApplicationManager.cpp (+8/-4)
unity-shared/BamfApplicationManager.h (+3/-1)
unity-shared/FileManager.h (+5/-6)
unity-shared/GnomeFileManager.cpp (+113/-86)
unity-shared/GnomeFileManager.h (+2/-5)
| Changed in ayatana-design: | |
| assignee: | nobody → John Lea (johnlea) |
| tags: | added: udp |
| Changed in ayatana-design: | |
| importance: | Undecided → Medium |
| Changed in unity: | |
| importance: | Undecided → Medium |
| Changed in unity (Ubuntu): | |
| importance: | Undecided → Medium |
| Changed in ayatana-design: | |
| status: | New → Triaged |
| Changed in unity: | |
| status: | New → Triaged |
| Changed in unity (Ubuntu): | |
| status: | New → Triaged |
| Changed in ayatana-design: | |
| status: | Triaged → Fix Committed |
| tags: | added: rls-w-incoming |
| tags: |
added: rls-x-incoming removed: rls-w-incoming |
| Changed in unity (Ubuntu): | |
| milestone: | none → ubuntu-16.04 |
| assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
| no longer affects: | unity |
| Changed in unity (Ubuntu): | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in unity (Ubuntu Xenial): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package unity - 7.4.0+16.
---------------
unity (7.4.0+
[ Didier Roche ]
* debian: Recommends session-shortcuts, prodiving easy way to
shutdown, reboot and logout from dash
[ Marco Trevisan (Treviño) ]
* CMake: use GNUInstallDirs with native multi-arch support (LP:
#1508635, #1485668)
* Launcher: add FileManager, Trash and Volume icons integration (LP:
#1524721, #1161323, #1063838, #1063823)
* SwitcherModel: avoid to access to invalid selection or to divide by
zero (LP: #1537524)
[ handsome_feng ]
* Extend the lockscreen theme for kylin.
-- Marco Trevisan (Treviño) <mail@3v1n0.net> Tue, 09 Feb 2016 12:21:15 +0000