Awn Extras

Please add Network UPS Tools support in battery applet

Bug #600408 reported by Arnaud Quette on 2010-06-30

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Awn Extras	Incomplete	Wishlist	Unassigned

Bug Description

this is related to a Debian bug / discussion (http://bugs.debian.org/565751).

it would be nice to add Network UPS Tools support (http://new.networkupstools.org) into the battery applet.

the archive is attached, and contain:

- the patch against the current bzr trunk battery.py,
- the directory themes/nut, which includes UPS pictures from Gnome Power Manager,
- a screenshot for illustrations (website, doc, ...).

Notes:

- this NUT support requires PyNUT which is still not in Debian nor Ubuntu: http://www.lestat.st/informatique/projets/pynut-en
- the NUT backend presence is tested at runtime. So, no extra package deps is needed,
- NUT support will be tested first, before HAL, and will try to connect to the first local UPS (which should cover most of the users need),
- only 1 local UPS is supported (support for multiple devices seems not to work, but it should not be needed),
- I'll probably consider adding a UPower backend too...

enjoy,
Arnaud

Tags:

Related branches

lp://staging/~aquette/awn-extras/battery-applet-nut-support

Revision history for this message

Arnaud Quette (aquette) wrote on 2010-06-30:

Complete patch Edit (78.9 KiB, application/x-bzip2)

Revision history for this message

Mark Lee (malept) wrote on 2010-06-30:

Thanks for the feature request + patch. Contributions like this are
greatly appreciated.

If it's not too much trouble, could you create a Bazaar branch of trunk
with your changes in it, uploaded to Launchpad? It makes it much easier
for us to merge your changes and attribute them to you. For more
information:

http://doc.bazaar-vcs.org/latest/en/mini-tutorial/index.html
http://doc.bazaar-vcs.org/latest/en/tutorials/using_bazaar_with_launchpad.html#accessing-code-in-launchpad-using-bazaar

Changed in awn-extras:
importance:	Undecided → Wishlist
status:	New → Incomplete

Revision history for this message

Arnaud Quette (aquette) wrote on 2010-07-01: Re: [Bug 600408] Re: Please add Network UPS Tools support in battery applet

2010/7/1 Mark Lee

> Thanks for the feature request + patch. Contributions like this are
> greatly appreciated.
>
> If it's not too much trouble, could you create a Bazaar branch of trunk
> with your changes in it, uploaded to Launchpad?
>

it won't hurt ;-)
just tell me where to publish it, ie personal or awn-extras branch?

cheers,
Arnaud
--
Linux / Unix Expert R&D - Eaton - http://www.eaton.com/mgeops
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.free.fr/

Revision history for this message

Mark Lee (malept) wrote on 2010-07-02:

An Awn Extras branch will do (by which I assume you mean lp:~username/awn-extras/branch-name).

Revision history for this message

Arnaud Quette (aquette) wrote on 2010-07-02:

2010/7/2 Mark Lee <email address hidden>

> An Awn Extras branch will do (by which I assume you mean lp:~username
> /awn-extras/branch-name).
>

done.
thanks to your pointers, I've even closed the bug with the commit ;-)
it's now on your side for a release.

Revision history for this message

Mark Lee (malept) wrote on 2010-07-02:

Well, not exactly :)

We can't merge the branch as-is, partly because I noticed that your changes don't conform to our coding standards. Our Python code uses Python's PEP8 as its coding standard <http://www.python.org/dev/peps/pep-0008/>, which you can easily check with a similarly named utility <http://pypi.python.org/pypi/pep8>.

We'd also prefer if you request a merge, as it's easier for us to comment on the changes you've made in there, rather than in a bug report.

onox (onox) on 2010-07-02

tags:

added: applet battery

Revision history for this message

onox (onox) wrote on 2010-07-02:

use: "device.type" in dev_vars
instead of: dev_vars.has_key( "device.type" )

Same goes for the line with ups.model.