The Avila project

[mali] egl_demo_client_flicker has graphics corruption on android

Bug #1517205 reported by Kevin DuBois on 2015-11-17

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Canonical Pocket Desktop	Fix Committed	High	kevin gunn
Mir	Fix Released	High	Kevin DuBois	Mir 0.20.0
The Avila project	In Progress	High	kevin gunn	The Avila project backlog
mir (Ubuntu)	Fix Released	High	Kevin DuBois

Bug Description

Investigation of lp: #1406725 yielded two different problems, this is the second problem that affected mir_demo_client_flicker most heavily.

When running mir_demo_client_flicker against "mir_demo_server --disable-overlays true", you could see cache-line artifacts, as well as an occasional tile-render-gpu artifact displayed on screen.

Tags:

Related branches

lp://staging/~kdub/mir/egl-sync-fences

Merged into lp://staging/mir at revision 3169

PS Jenkins bot (community): Approve (continuous-integration) on 2015-12-02

Alan Griffiths: Approve on 2015-12-02

Cemil Azizoglu (community): Approve on 2015-12-02

Andreas Pokorny (community): Approve on 2015-11-30

Diff: 1322 lines (+420/-48)

44 files modified

include/renderers/gl/mir/renderer/gl/texture_source.h (+10/-0)
src/common/graphics/android/CMakeLists.txt (+1/-0)
src/common/graphics/android/android_native_buffer.cpp (+15/-1)
src/gl/recently_used_cache.cpp (+8/-7)
src/include/common/mir/graphics/android/android_native_buffer.h (+6/-0)
src/include/common/mir/graphics/android/native_buffer.h (+3/-0)
src/platform/symbols.map (+14/-0)
src/platforms/android/client/CMakeLists.txt (+2/-0)
src/platforms/android/client/gralloc_registrar.cpp (+3/-1)
src/platforms/android/server/CMakeLists.txt (+1/-0)
src/platforms/android/server/android_alloc_adaptor.cpp (+12/-5)
src/platforms/android/server/android_alloc_adaptor.h (+6/-2)
src/platforms/android/server/android_buffer_allocator.cpp (+10/-4)
src/platforms/android/server/android_graphic_buffer_allocator.h (+5/-1)
src/platforms/android/server/buffer.cpp (+23/-4)
src/platforms/android/server/buffer.h (+6/-0)
src/platforms/android/server/cmdstream_sync_factory.h (+48/-0)
src/platforms/android/server/display_component_factory.h (+2/-0)
src/platforms/android/server/egl_sync_factory.cpp (+34/-0)
src/platforms/android/server/hal_component_factory.cpp (+15/-0)
src/platforms/android/server/hal_component_factory.h (+3/-1)
src/platforms/android/server/ipc_operations.cpp (+1/-0)
src/platforms/android/server/platform.cpp (+10/-4)
src/platforms/android/server/platform.h (+3/-0)
src/platforms/mesa/server/common/gbm_buffer.cpp (+9/-0)
src/platforms/mesa/server/common/gbm_buffer.h (+2/-0)
src/platforms/mesa/server/common/shm_buffer.cpp (+9/-0)
src/platforms/mesa/server/common/shm_buffer.h (+2/-0)
tests/include/mir/test/doubles/mock_android_native_buffer.h (+2/-0)
tests/include/mir/test/doubles/mock_buffer.h (+1/-0)
tests/include/mir/test/doubles/mock_gl_buffer.h (+2/-0)
tests/include/mir/test/doubles/stub_android_native_buffer.h (+3/-0)
tests/include/mir/test/doubles/stub_cmdstream_sync_factory.h (+41/-0)
tests/include/mir/test/doubles/stub_display_builder.h (+5/-0)
tests/include/mir/test/doubles/stub_gl_buffer.h (+2/-0)
tests/integration-tests/graphics/mesa/test_buffer_integration.cpp (+3/-0)
tests/unit-tests/gl/test_gl_texture_cache.cpp (+3/-1)
tests/unit-tests/gl/test_program_factory.cpp (+1/-1)
tests/unit-tests/graphics/android/test_android_alloc_adaptor.cpp (+5/-2)
tests/unit-tests/graphics/android/test_android_buffer_allocator.cpp (+6/-2)
tests/unit-tests/graphics/android/test_buffer_tex_bind.cpp (+13/-1)
tests/unit-tests/graphics/android/test_display_hotplug.cpp (+5/-0)
tests/unit-tests/graphics/android/test_native_buffer.cpp (+50/-7)
tests/unit-tests/graphics/android/test_platform.cpp (+15/-4)

lp://staging/~kdub/mir/egl-sync-khr

Merged into lp://staging/mir at revision 3137

Alan Griffiths: Approve on 2015-11-26

Chris Halse Rogers: Approve on 2015-11-26

PS Jenkins bot (community): Approve (continuous-integration) on 2015-11-25

Alberto Aguirre (community): Approve on 2015-11-20

lp://staging/~kdub/mir/revert-sync-factory

Merged into lp://staging/mir at revision 3194

Daniel van Vugt: Approve on 2015-12-15

PS Jenkins bot (community): Approve (continuous-integration) on 2015-12-14

Cemil Azizoglu (community): Approve on 2015-12-14

Alan Griffiths: Approve on 2015-12-14

Diff: 1599 lines (+64/-490)

57 files modified

include/renderers/gl/mir/renderer/gl/texture_source.h (+0/-10)
src/common/graphics/android/CMakeLists.txt (+0/-1)
src/common/graphics/android/android_native_buffer.cpp (+1/-15)
src/gl/recently_used_cache.cpp (+7/-8)
src/include/common/mir/graphics/android/android_native_buffer.h (+0/-6)
src/include/common/mir/graphics/android/native_buffer.h (+0/-3)
src/platform/symbols.map (+0/-14)
src/platforms/android/client/CMakeLists.txt (+0/-2)
src/platforms/android/client/gralloc_registrar.cpp (+1/-3)
src/platforms/android/server/CMakeLists.txt (+0/-1)
src/platforms/android/server/android_alloc_adaptor.cpp (+5/-12)
src/platforms/android/server/android_alloc_adaptor.h (+2/-6)
src/platforms/android/server/android_buffer_allocator.cpp (+4/-10)
src/platforms/android/server/android_graphic_buffer_allocator.h (+1/-5)
src/platforms/android/server/buffer.cpp (+4/-23)
src/platforms/android/server/buffer.h (+0/-6)
src/platforms/android/server/cmdstream_sync_factory.h (+0/-48)
src/platforms/android/server/display_buffer.cpp (+0/-3)
src/platforms/android/server/display_component_factory.h (+0/-2)
src/platforms/android/server/display_device.h (+0/-2)
src/platforms/android/server/egl_sync_factory.cpp (+0/-34)
src/platforms/android/server/fb_device.cpp (+2/-5)
src/platforms/android/server/fb_device.h (+0/-1)
src/platforms/android/server/hal_component_factory.cpp (+0/-15)
src/platforms/android/server/hal_component_factory.h (+1/-3)
src/platforms/android/server/hwc_device.cpp (+6/-11)
src/platforms/android/server/hwc_device.h (+0/-1)
src/platforms/android/server/hwc_fb_device.cpp (+0/-5)
src/platforms/android/server/hwc_fb_device.h (+0/-1)
src/platforms/android/server/ipc_operations.cpp (+0/-1)
src/platforms/android/server/platform.cpp (+4/-10)
src/platforms/android/server/platform.h (+0/-3)
src/platforms/mesa/server/common/gbm_buffer.cpp (+0/-9)
src/platforms/mesa/server/common/gbm_buffer.h (+0/-2)
src/platforms/mesa/server/common/shm_buffer.cpp (+0/-9)
src/platforms/mesa/server/common/shm_buffer.h (+0/-2)
tests/include/mir/test/doubles/mock_android_native_buffer.h (+0/-2)
tests/include/mir/test/doubles/mock_buffer.h (+0/-1)
tests/include/mir/test/doubles/mock_display_device.h (+0/-3)
tests/include/mir/test/doubles/mock_gl_buffer.h (+0/-2)
tests/include/mir/test/doubles/stub_android_native_buffer.h (+0/-3)
tests/include/mir/test/doubles/stub_cmdstream_sync_factory.h (+0/-41)
tests/include/mir/test/doubles/stub_display_builder.h (+0/-5)
tests/include/mir/test/doubles/stub_gl_buffer.h (+0/-2)
tests/integration-tests/graphics/mesa/test_buffer_integration.cpp (+0/-3)
tests/unit-tests/gl/test_gl_texture_cache.cpp (+1/-3)
tests/unit-tests/gl/test_program_factory.cpp (+1/-1)
tests/unit-tests/graphics/android/test_android_alloc_adaptor.cpp (+2/-5)
tests/unit-tests/graphics/android/test_android_buffer_allocator.cpp (+2/-6)
tests/unit-tests/graphics/android/test_buffer_tex_bind.cpp (+1/-13)
tests/unit-tests/graphics/android/test_display_buffer.cpp (+0/-15)
tests/unit-tests/graphics/android/test_display_hotplug.cpp (+0/-5)
tests/unit-tests/graphics/android/test_fb_device.cpp (+0/-8)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+8/-9)
tests/unit-tests/graphics/android/test_hwc_fb_device.cpp (+0/-6)
tests/unit-tests/graphics/android/test_native_buffer.cpp (+7/-50)
tests/unit-tests/graphics/android/test_platform.cpp (+4/-15)

lp://staging/~kdub/mir/refix-1517205

Merged into lp://staging/mir at revision 3297

PS Jenkins bot (community): Approve (continuous-integration) on 2016-02-08

Alexandros Frantzis (community): Approve on 2016-02-08

Mir CI Bot: Approve (continuous-integration) on 2016-02-08

Alan Griffiths: Approve on 2016-02-08

Diff: 2060 lines (+730/-149)

71 files modified

include/renderers/gl/mir/renderer/gl/texture_source.h (+10/-0)
src/gl/recently_used_cache.cpp (+8/-7)
src/include/platform/mir/graphics/egl_extensions.h (+0/-8)
src/platform/graphics/CMakeLists.txt (+0/-1)
src/platform/graphics/egl_extensions.cpp (+0/-12)
src/platforms/android/client/CMakeLists.txt (+1/-0)
src/platforms/android/client/gralloc_registrar.cpp (+4/-2)
src/platforms/android/common/CMakeLists.txt (+2/-0)
src/platforms/android/common/android_native_buffer.cpp (+18/-4)
src/platforms/android/common/egl_sync_extensions.cpp (+35/-0)
src/platforms/android/common/egl_sync_fence.cpp (+1/-1)
src/platforms/android/include/android/native_window.h (+21/-0)
src/platforms/android/include/android_native_buffer.h (+6/-0)
src/platforms/android/include/command_stream_sync.h (+51/-0)
src/platforms/android/include/egl_sync_extensions.h (+48/-0)
src/platforms/android/include/egl_sync_fence.h (+2/-21)
src/platforms/android/include/native_buffer.h (+3/-0)
src/platforms/android/server/CMakeLists.txt (+1/-0)
src/platforms/android/server/android_alloc_adaptor.cpp (+12/-5)
src/platforms/android/server/android_alloc_adaptor.h (+6/-2)
src/platforms/android/server/android_buffer_allocator.cpp (+10/-4)
src/platforms/android/server/android_graphic_buffer_allocator.h (+5/-1)
src/platforms/android/server/buffer.cpp (+23/-4)
src/platforms/android/server/buffer.h (+6/-0)
src/platforms/android/server/cmdstream_sync_factory.h (+48/-0)
src/platforms/android/server/device_quirks.cpp (+6/-0)
src/platforms/android/server/device_quirks.h (+1/-0)
src/platforms/android/server/display_buffer.cpp (+3/-0)
src/platforms/android/server/display_component_factory.h (+2/-0)
src/platforms/android/server/display_device.h (+2/-0)
src/platforms/android/server/egl_sync_factory.cpp (+35/-0)
src/platforms/android/server/fb_device.cpp (+5/-2)
src/platforms/android/server/fb_device.h (+1/-0)
src/platforms/android/server/hal_component_factory.cpp (+20/-1)
src/platforms/android/server/hal_component_factory.h (+4/-1)
src/platforms/android/server/hwc_device.cpp (+11/-6)
src/platforms/android/server/hwc_device.h (+1/-0)
src/platforms/android/server/hwc_fb_device.cpp (+5/-0)
src/platforms/android/server/hwc_fb_device.h (+1/-0)
src/platforms/android/server/ipc_operations.cpp (+1/-0)
src/platforms/android/server/platform.cpp (+10/-4)
src/platforms/android/server/platform.h (+3/-0)
src/platforms/mesa/server/common/gbm_buffer.cpp (+9/-0)
src/platforms/mesa/server/common/gbm_buffer.h (+2/-0)
src/platforms/mesa/server/common/shm_buffer.cpp (+9/-0)
src/platforms/mesa/server/common/shm_buffer.h (+2/-0)
tests/include/mir/test/doubles/mock_android_native_buffer.h (+2/-0)
tests/include/mir/test/doubles/mock_buffer.h (+1/-0)
tests/include/mir/test/doubles/mock_display_device.h (+3/-0)
tests/include/mir/test/doubles/mock_gl_buffer.h (+2/-0)
tests/include/mir/test/doubles/stub_android_native_buffer.h (+3/-0)
tests/include/mir/test/doubles/stub_cmdstream_sync_factory.h (+41/-0)
tests/include/mir/test/doubles/stub_display_builder.h (+5/-0)
tests/include/mir/test/doubles/stub_gl_buffer.h (+2/-0)
tests/integration-tests/graphics/mesa/test_buffer_integration.cpp (+3/-0)
tests/unit-tests/gl/test_gl_texture_cache.cpp (+3/-1)
tests/unit-tests/gl/test_program_factory.cpp (+1/-1)
tests/unit-tests/graphics/android/CMakeLists.txt (+1/-0)
tests/unit-tests/graphics/android/test_android_alloc_adaptor.cpp (+6/-3)
tests/unit-tests/graphics/android/test_android_buffer_allocator.cpp (+6/-2)
tests/unit-tests/graphics/android/test_buffer_tex_bind.cpp (+13/-1)
tests/unit-tests/graphics/android/test_display_buffer.cpp (+15/-0)
tests/unit-tests/graphics/android/test_display_hotplug.cpp (+5/-0)
tests/unit-tests/graphics/android/test_egl_sync_extensions.cpp (+75/-0)
tests/unit-tests/graphics/android/test_fb_device.cpp (+8/-0)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+9/-8)
tests/unit-tests/graphics/android/test_hwc_fb_device.cpp (+6/-0)
tests/unit-tests/graphics/android/test_native_buffer.cpp (+50/-7)
tests/unit-tests/graphics/android/test_platform.cpp (+15/-4)
tests/unit-tests/graphics/test_egl_extensions.cpp (+0/-35)
tests/unit-tests/graphics/test_egl_sync_fence.cpp (+1/-1)

lp://staging/~mir-team/mir/0.18.2

Rejected for merging into lp://staging/mir/0.18

Kevin DuBois (community): Disapprove on 2016-01-28

Daniel van Vugt: Needs Information on 2016-01-28

Revision history for this message

Kevin DuBois (kdub) wrote on 2015-11-17:

Diagnosis of this bug: https://bugs.launchpad.net/mir/+bug/1406725/comments/21

Revision history for this message

Kevin DuBois (kdub) wrote on 2015-11-20:

Attached branch fixes up adreno devices, still searching for why mali ones have corruption

Revision history for this message

Kevin DuBois (kdub) wrote on 2015-11-20:

I'm pretty sure that although visually similar, the corruption happening on krillin after applying lp:~kdub/mir/egl-sync-khr has the same root cause as lp: #1270245.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-27:

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.18.0

Changed in mir:
status:	In Progress → Fix Committed

Revision history for this message

Kevin DuBois (kdub) wrote on 2015-11-30:

one of the chain of branches landed and jenkins toggled to fixed. Switching back to 'in progress' until lp:~kdub/mir/egl-sync-fences lands

Changed in mir:
status:	Fix Committed → In Progress
milestone:	0.18.0 → 0.19.0

Daniel van Vugt (vanvugt) on 2015-12-03

tags:	removed: xmir
Changed in mir:
importance:	Critical → High

Daniel van Vugt (vanvugt) on 2015-12-09

Changed in mir:
status:	In Progress → Fix Committed
milestone:	0.19.0 → 0.18.0

Revision history for this message

Kevin DuBois (kdub) wrote on 2015-12-11:

The fix here exposes a driver bug:
https://bugs.launchpad.net/mir/+bug/1524414

Will revert this fix until a solution is found to accommodate the mx4 driver bug.

Changed in mir:
status:	Fix Committed → In Progress
milestone:	0.18.0 → 0.19.0

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-15:

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.19.0

Changed in mir:
status:	In Progress → Fix Committed

Daniel van Vugt (vanvugt) on 2015-12-15

Changed in mir:
status:	Fix Committed → In Progress

Brandon Schaefer (brandontschaefer) on 2016-01-19

Changed in mir:
milestone:	0.19.0 → 0.20.0

kevin gunn (kgunn72) on 2016-01-25

summary:	- egl_demo_client_flicker has graphics corruption on android + [mali gpu] egl_demo_client_flicker has graphics corruption on android
Changed in canonical-pocket-desktop:
assignee:	nobody → kevin gunn (kgunn72)
importance:	Undecided → High
Changed in mir (Ubuntu):
importance:	Undecided → High
assignee:	nobody → Kevin DuBois (kdub)
Changed in canonical-pocket-desktop:
status:	New → In Progress
Changed in mir (Ubuntu):
status:	New → In Progress

Daniel van Vugt (vanvugt) on 2016-01-28

Changed in mir (Ubuntu):
status:	In Progress → Triaged

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2016-01-28: Re: [mali gpu] egl_demo_client_flicker has graphics corruption on android

Wait, did we commit a fix to lp:mir/0.19 already?

------------------------------------------------------------
revno: 3273
committer: Kevin DuBois <email address hidden>
branch nick: 0.19
timestamp: Wed 2016-01-27 11:46:59 -0500
message:
add autodection for the fb ion quirk
------------------------------------------------------------

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2016-01-29:

Hmm, nope. r3273 appears to be unrelated to this bug. No fix planned for 0.19 yet. Only in 0.20 and 0.18 (??)

kevin gunn (kgunn72) on 2016-02-09

no longer affects:	mir/0.18
no longer affects:	mir/0.19

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-09:

#10

Fix committed into lp:mir at revision 3297, scheduled for release in mir, milestone 0.20.0

Changed in mir:
status:	In Progress → Fix Committed

Daniel van Vugt (vanvugt) on 2016-02-10

tags:	added: mali
summary:	- [mali gpu] egl_demo_client_flicker has graphics corruption on android + [mali] egl_demo_client_flicker has graphics corruption on android

John McAleely (john.mcaleely) on 2016-02-10

Changed in avila:
status:	New → In Progress
milestone:	none → ww06-2016
importance:	Undecided → High

John McAleely (john.mcaleely) on 2016-02-12

Changed in avila:
assignee:	nobody → kevin gunn (kgunn72)

kevin gunn (kgunn72) on 2016-02-12

Changed in mir (Ubuntu):
status:	Triaged → Fix Committed

Daniel van Vugt (vanvugt) on 2016-02-15

Changed in mir (Ubuntu):
status:	Fix Committed → Triaged

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-02-23:

#11

Download full text (3.3 KiB)

This bug was fixed in the package mir - 0.20.0+16.04.20160219-0ubuntu1

---------------
mir (0.20.0+16.04.20160219-0ubuntu1) xenial; urgency=medium

  [ Alan Griffiths ]
  * New upstream release 0.20.0 (https://launchpad.net/mir/+milestone/0.20.0)
    - ABI summary: Only servers need rebuilding;
      . mirclient ABI unchanged at 9
      . mirserver ABI bumped to 38
      . mircommon ABI unchanged at 5
      . mirplatform ABI unchanged at 11
      . mirprotobuf ABI unchanged at 3
      . mirplatformgraphics ABI bumped to 8
      . mirclientplatform ABI unchanged at 4
      . mirinputplatform ABI unchanged at 5
    - Enhancements:
      . Allow screencasting to create a virtual output (for Miracast)
      . Separate the protocol version number from the client API version macros.
        They're not meant to be related concepts.
      . Add UBSanitizer to the list of build types.
      . logging: Human readable timestamps in DumbConsoleLogger.
      . examples: AdorningDisplayBufferCompositor::composite() no long ignores
        output boundaries and occlusions.
      . examples: Add -a <app name> option to eglapps.
      . common, client: a more flexible way to probe modules: once we've found
        a good current platform we don't even try to load an older one.
      . Fix build and test run with CMAKE_BUILD_TYPE=ThreadSanitizer (missing
        locks).
      . Add MIR_USE_LD_GOLD build option.
    - Bug fixes:
      . unity-system-compositor crashed with std::runtime_error in
        mir::compositor::CompositingFunctor::wait_until_started() from
        usc::MirScreen::set_screen_power_mode (mir_power_mode_on)
        (LP: #1528384)
      . Phone not usable while a call comes in - followed by "restart"
        (LP: #1532607)
      . ui freezes when simultaneously moving mouse & plug/unplug hdmi
        (LP: #1538632)
      . Mir fails to build on xenial today: android_graphic_buffer_allocator.h
        fatal error: hardware/hardware.h: No such file or directory
        (LP: #1539338)
      . [mali] egl_demo_client_flicker has graphics corruption on android
        (LP: #1517205)
      . [testsfail] Intermittent failure in
        TestClientCursorAPI.cursor_passed_through_nested_server (LP: #1525003)
      . [android] External monitor slows rendering (LP: #1532202)
      . Display::create_gl_context may create context with incorrect attributes
        (LP: #1539268)
      . unity-system-compositor locked up in __libc_do_syscall() (LP: #1543594)
      . NestedServer.client_sees_set_scaling_factor intermittent failure
        (LP: #1537798)
      . [android] External monitor slows rendering - part 2 (LP: #1535894)
      . scene: make sure not to set the swapinterval to 0 when an independent
        stream is created. The default should be 1 (like the stream created as
        part of surface creation).
      . Track the displays plugged state to avoid reporting configurations in
        case they are unplugged (LP #1531503). [Cherrypicked from 0.21]
      . mouse pointer support on emulator is broken (LP: #1517597).
        [Cherrypicked from 0.21]
      . move an android-only test that ended up in tests/unit-tests/graphics.
        (LP: ##154...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.