Auto Package Testing

autopkgtest environment should have ::1 in no_proxy

Bug #1945634 reported by Paride Legovini on 2021-09-30

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Auto Package Testing	Triaged	Wishlist	Unassigned
	ulfius (Ubuntu)	Fix Released	Undecided	Paride Legovini

Bug Description

Currently the autopkgtest environment runs the tests with 127.0.0.1 in the no_proxy env variable, doing this (from [1]):

no_proxy=127.0.0.1,127.0.1.1,localhost,localdomain,novalocal,internal,archive.ubuntu.com,security.ubuntu.com,ddebs.ubuntu.com,changelogs.ubuntu.com,launchpad.net,10.24.0.0/24

but it doesn't add ::1, which is the equivalent of 127.0.0.1 in the IPv6 world. This can cause IPv6 test failures as http connections to ::1 are passed to http_proxy (= to squid.internal:3128), which is wrong.

The solution to this is to append "::1" to that list of hosts.

[1] https://autopkgtest.ubuntu.com/results/autopkgtest-impish/impish/amd64/u/ulfius/20210909_151401_cd5b1@/log.gz

Tags:

Paride Legovini (paride) on 2021-09-30

Changed in ulfius (Ubuntu):
status:	New → Triaged
assignee:	nobody → Paride Legovini (paride)

Revision history for this message

Paride Legovini (paride) wrote on 2021-09-30:

lp1945634-ulfius-impish.debdiff Edit (1.5 KiB, text/plain)

Attaching debdiff with a workaround for ulfius.

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2021-09-30:

Hmm
[ -n "$no_proxy" ] && no_proxy="$no_proxy,::1"

That means if it has content ensure that ::1 also is in it.
Should we check if ::1 is already in it?

Revision history for this message

Paride Legovini (paride) wrote on 2021-09-30:

Checking for ::1 being already present it not completely trivial as we need to make sure that it's not part of longer addresses, while taking into account that it can be at the beginning and end of string...

Having it twice won't hurt, and hopefully this delta won't be long lived. I'd take the simple route and keep the change as proposed.

tags:

added: update-excuse

Revision history for this message

Paride Legovini (paride) wrote on 2021-09-30:

lp1945634-ulfius-impish.debdiff Edit (1.7 KiB, text/plain)

Updated debdiff, added an explanatory comment.

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2021-09-30:

Thanks for the workaround, I agree and sponsored it.

But I also think - unless there is a strong reason against it we miss - that this should be added by the environment by default. Therefore bumping the severity up there.

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2021-09-30:

Uh, I can't bump it, but whoever triages this for autopkgtest infra feel bumped :-)
Thanks in advance!

Revision history for this message

Julian Andres Klode (juliank) wrote on 2021-09-30:

We added ::1 on Dec 4 2020, but had to revert it on Dec 14 due to LP: #1908136

Changed in auto-package-testing:
importance:	Undecided → Wishlist
status:	New → Confirmed
status:	Confirmed → Triaged

Christian Ehrhardt  (paelzer) on 2021-09-30

Changed in ulfius (Ubuntu):
status:	Triaged → Fix Committed

Ubuntu Foundations Team Bug Bot (crichton) on 2021-09-30

tags:

added: patch

Revision history for this message

Gianfranco Costamagna (costamagnagianfranco) wrote on 2021-09-30:

oops I found this after syncing the package.
I added again this diff on top of the new version, will upload once the current sync is published so we have autopkgtest run saved.
thanks!

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-09-30:

This bug was fixed in the package ulfius - 2.7.1-3ubuntu1

---------------
ulfius (2.7.1-3ubuntu1) impish; urgency=medium

* d/t/unit-test: run with ::1 in no_proxy (LP: #1945634)

-- Paride Legovini <email address hidden> Thu, 30 Sep 2021 13:52:58 +0200

Changed in ulfius (Ubuntu):
status:	Fix Committed → Fix Released

Revision history for this message

Brian Murray (brian-murray) wrote on 2022-08-30:

#10

We should reinvestigate adding this to address to the no_proxy environment variable in the infrastructure.

Revision history for this message

Paride Legovini (paride) wrote on 2022-08-31:

#11

We can consider SRUing this curl fix:

https://github.com/curl/curl/commit/b7f90470be9b75f57167abbcd63aadb2e3b33958

I filed https://bugs.launchpad.net/curl/+bug/1988290 to track the status of that bug in Ubuntu.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Patches

Add patch

Remote bug watches

Bug watches keep track of this bug in other bug trackers.