The mini-video-preview thingy doesn't take into account aspect ratio
Bug #1163695 reported by
Volodymyr Shatsky
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Audience |
Fix Released
|
Undecided
|
Volodymyr Shatsky |
Bug Description
First of all — it's the most incredible feature ever, thank you so much. But it would be even better if you keep the aspect ratio.
Related branches
lp://staging/~shockone89/audience/fix-1163695
- Tom Beckmann: Approve
-
Diff: 132 lines (+48/-9)5 files modifiedAudience/Audience.vala (+36/-0)
Audience/Utils.vala (+8/-6)
Audience/Widgets/MediaSlider.vala (+1/-1)
Audience/Widgets/TagView.vala (+2/-2)
Audience/Widgets/VideoPlayer.vala (+1/-0)
summary: |
- The mini-video-preview thing doesn't take into account aspect ration + The mini-video-preview thingy doesn't take into account aspect ratio |
Changed in audience: | |
status: | New → Fix Committed |
assignee: | nobody → Volodymyr Shatsky (shockone89) |
Changed in audience: | |
milestone: | none → freya-beta2 |
Changed in audience: | |
status: | Fix Committed → Fix Released |
Changed in audience: | |
milestone: | freya-beta2 → 0.1 |
To post a comment you must log in.
Not sure if it's the best way possible, but it works. Add the following line before the return of VideoPlayer# relayout (file VideoPlayer.vala, line 447): slider. preview. width = (float)video_width / video_height * controls. slider. preview. height;
controls.