The mini-video-preview thingy doesn't take into account aspect ratio

Bug #1163695 reported by Volodymyr Shatsky
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Audience
Fix Released
Undecided
Volodymyr Shatsky

Bug Description

First of all — it's the most incredible feature ever, thank you so much. But it would be even better if you keep the aspect ratio.

Related branches

summary: - The mini-video-preview thing doesn't take into account aspect ration
+ The mini-video-preview thingy doesn't take into account aspect ratio
Revision history for this message
Volodymyr Shatsky (shockone89) wrote :

Not sure if it's the best way possible, but it works. Add the following line before the return of VideoPlayer#relayout (file VideoPlayer.vala, line 447):
controls.slider.preview.width = (float)video_width / video_height * controls.slider.preview.height;

Revision history for this message
Volodymyr Shatsky (shockone89) wrote :

Is it good enough for pull request? I think we can also delete the preview.width = 120.0f; from MediaSlider.vala

Revision history for this message
Tom Beckmann (tombeckmann) wrote :

Please propose one, I will test it in all detail then :)

Revision history for this message
Cody Garver (codygarver) wrote :

bzr branch lp:audience
cd audience
# make some changes
bzr commit -m "I made some changes." --fixes=lp:1163695
bzr push lp:~shockone89/audience/fix-1163695
# visit code.launchpad.net/~shockone89/audience/fix-1163695 and click "Propose for merge"

If you need help setting up bzr: http://tiny.cc/dev-guide-draft

Changed in audience:
status: New → Fix Committed
assignee: nobody → Volodymyr Shatsky (shockone89)
Changed in audience:
milestone: none → freya-beta2
Changed in audience:
status: Fix Committed → Fix Released
Cody Garver (codygarver)
Changed in audience:
milestone: freya-beta2 → 0.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.