Community App Catalog

Last modified date missing from api/v1/assets

Bug #1553572 reported by Christopher Aedo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Community App Catalog
In Progress
Medium
Christopher Aedo

Bug Description

Each asset should have a last_modified date associated with it in the JSON output from api/v1/assets. This data is blank on the web site, though on local tests the data is populated.

To reproduce, check out app-catalog repo, run "./run_tests.sh --runserver", then compare the generated assets file (at openstack_catalog/web/api/v1/assets) to http://apps.openstack.org/api/v1/assets

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to app-catalog (master)

Fix proposed to branch: master
Review: https://review.openstack.org/291489

Changed in app-catalog:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to app-catalog (master)

Reviewed: https://review.openstack.org/291489
Committed: https://git.openstack.org/cgit/openstack/app-catalog/commit/?id=d43bc0a0281fccc96d9d19de658341cbc6686eea
Submitter: Jenkins
Branch: master

commit d43bc0a0281fccc96d9d19de658341cbc6686eea
Author: Christopher Aedo <email address hidden>
Date: Thu Mar 10 15:39:29 2016 -0800

    Keep assets_merge.yaml

    This commit removes the line that deleted assets_merge.yaml. This
    file is left in place so someone from the infra team can SSH to the
    box and validate whether or not the fields are being populated
    correctly on the production server.

    This will not resolve the linked bug, but will be a big aid in
    tracking down the cause.

    Change-Id: I9c9f3f80b5e702e6c259787df741a5f963286688
    Partial-Bug: 1553572

Revision history for this message
Christopher Aedo (docaedo) wrote :

I can recreate locally by stripping the dates from assets_merge.yaml. Considering that, and the fact that "last_modified" field exists but is empty in the generated assets JSON, it's almost certainly caused by the script that finds the last_modified day malfunctioning on the production server.

Specifically this script: http://git.openstack.org/cgit/openstack/app-catalog/tree/tools/asset_history.sh

This could be caused by the server having an older version of git, or maybe git on the server has a different output that fails to get picked up properly by the script.

Revision history for this message
Christopher Aedo (docaedo) wrote :

Closing this as "won't fix" because we will be replacing the back end with glare, so the "when was this asset added/updated" info will be saved and retrieved differently.

Changed in app-catalog:
status: In Progress → Won't Fix
Revision history for this message
Christopher Aedo (docaedo) wrote :

Couldn't help looking at this again. When tools/asset_history.sh is run on a clean/new ubuntu 14 server (that had puppet-apps_site manifest applied to it), the error "ImportError: No module named dateutil.parser" pops up. This can be remedied by running "pip install python-dateutil".

Changed in app-catalog:
status: Won't Fix → Triaged
Christopher Aedo (docaedo)
Changed in app-catalog:
status: Triaged → In Progress
Revision history for this message
Christopher Aedo (docaedo) wrote :

Fix proposed in https://review.openstack.org/#/c/358909/

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.