BLT

blt checks for content every launch

Bug #236286 reported by Jon Levell
2
Affects Status Importance Assigned to Milestone
BLT
New
Undecided
Unassigned

Bug Description

Because BLT stores the tweet id (not a time) in the last fetch file, the line that decides whether to check or it's too soon compares
a tweet id with a time - and always decides to check.

I think storing the tweet id is the right thing to do (it fixes bug #222528) but we probably ought to store the time as well so we
can decide when to check again.

I don't have a patch for this one at the moment, unless your planning on working on it in the next few days, I'll try and get a
patch together at some point this week

Revision history for this message
Jon Levell (d-launchpad-coralbark-net) wrote :

I'll attach here my modified versions I'm currently using - it not a patch as I'm not sure what to patch against - the attached files contain my uptodate sources with
all the fixes - it's working pretty well for me at the moment. If you'd prefer patches against a specific SVN version let me know

Revision history for this message
Jon Levell (d-launchpad-coralbark-net) wrote :

BLT.pm in the above attachment has a bug that if the twitter get request doesn't success it carries on regardless :/

  unless ($response->is_success) {
    update_last_fetch( $greatest_tweet_seen, $attempt_time, $previous_successtime);
  }

should read:

  unless ($response->is_success) {
    update_last_fetch( $greatest_tweet_seen, $attempt_time, $previous_successtime);
    return "blt: failed to get data from twitter; ".$response->status_line."\n";
  }

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.