AnewtCalendar uses incorrect date/datetime syntax

Bug #717882 reported by Jasper Looije
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Anewt
Confirmed
Undecided
wouter bolsterlee

Bug Description

AnewtCalendar renders date components in VEVENT incorrectly. Acording to the RFC5545 by default a date-time stamp (separeted by a T, iso8601) is expected. In the case of an all-day event (e.g. anniversary) only the date is suplied.

Currently all date components (DTSTAMP DTSTART DTEND) are rendered as if there is no time-part:

DTSTAMP; VALUE=DATE:20110212T220900

The presens of the time part is wrong, because the VALUE=DATE implies only a date.

Correct behavior should be

- in case of a full timestamp:
DTSTART:20110212T220900

- in case of an all-day event
DTSTART; VALUE=DATE:20110212

Changed in anewt:
assignee: nobody → Jasper Looije (jasper-jamu)
Revision history for this message
Jasper Looije (jasper-jamu) wrote :

Attached patch generates correct ical output. In my test script following warning is generated:

PHP Warning: assert(): Assertion "is_int($timestamp);" failed in /home/jasper/code/anewt/core/datetime.lib.php on line 202

I am not sure wether my patch triggers this or it is my test script.

Revision history for this message
Jasper Looije (jasper-jamu) wrote :

Hmm, my patch contained a stupid copy 'n paste bug

Revision history for this message
Jasper Looije (jasper-jamu) wrote :

In addition to the in #1 mentioned warning: it was my test script which triggered it.

Changed in anewt:
assignee: Jasper Looije (jasper-jamu) → Wouter Bolsterlee (uws) (uws)
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.