Activity Log Manager

The "+" button should have a ▾ menu triangle.

Bug #1198367 reported by Manish Sinha (मनीष सिन्हा)
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Activity Log Manager
Confirmed
Low
Unassigned
Activity Log Manager 0.9.8

Bug Description

As per mpt,
At the moment the [ + ] icons for adding Exclude contains a submenu but it is not clear because there is no ▾ label attached to it.

See original description

Related branches

lp://staging/~jbicha/activity-log-manager/fix-add-popup
Manish Sinha (मनीष सिन्हा): Approve
Diff: 67 lines (+10/-10)
2 files modified
src/activity-log-manager.vala (+1/-1)
src/unified-privacy.vala (+9/-9)
Manish Sinha (मनीष सिन्हा) (manishsinha)
Changed in activity-log-manager:
assignee: nobody → Manish Sinha (मनीष सिन्हा) (manishsinha)
importance: Undecided → Low
milestone: none → 0.9.7
status: New → Confirmed
description: updated
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Manish, I think I can fix this one.

Changed in activity-log-manager:
assignee: Manish Sinha (मनीष सिन्हा) (manishsinha) → Jeremy Bicha (jbicha)
Jeremy Bícha (jbicha)
Changed in activity-log-manager:
assignee: Jeremy Bicha (jbicha) → nobody
Revision history for this message
Jeremy Bícha (jbicha) wrote :

The drop-down arrow is usually an icon, "go-down-symbolic". By default, GTK widgets tend to support a label and an icon but this bug report is requesting two icons (the other is "list-add-symbolic"). I'm sure it's possible to subclass the widget to allow that but it's a bit of work.

I have a merge proposal which makes the add menu appear to drop down out of the entire + button instead of popping up wherever is clicked. This is basically the same way the gear menu works in Nautilus 3.6+ for instance.

With that fix, I'm not so sure we need an extra down arrow next to the + button.

Manish Sinha (मनीष सिन्हा) (manishsinha)
Changed in activity-log-manager:
milestone: 0.9.7 → 0.9.8
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.