[reminder app] Empty account name shown on initial screen
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evernote Online Accounts plugin |
Fix Released
|
High
|
Michael Zanetti | ||
Ubuntu Notes app |
Fix Released
|
High
|
Michael Zanetti | ||
Ubuntu UX |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
Steps to reproduce (on the phone):
1. Start Reminders
2. See the initial screen with a prompt to select an Evernote account to work with
Actual:
- The name of the Evernote account(s) to pick is empty
- You can click on the empty space and it choses the right account
Expected:
- The user name of the Evernote account registered in System Settings is shown
- If there is only one registered account, skip the initial screen and just use that one (this will need validation from design)
The name not being shown is due to the fact that the Evernote user name for the account (what would generally be used as display name for that account) is not picked up by the Evernote authentication plugin on the phone. The authentication plugin needs to talk to Evernote to retrieve the user info via the shipped Main.qml file shipped in the plugin's package. This will probably mean that the Evernote API QML plugin will need to be used (and shipped) by the Evernote authentication plugin.
Related branches
- Alan Pope πΊπ§π± π¦ (community): Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 1692 lines (+720/-345)30 files modifiedsrc/app/qml/reminders-app.qml (+8/-1)
src/app/qml/ui/AccountSelectorPage.qml (+1/-1)
src/plugin/Evernote/Evernote.pro (+10/-2)
src/plugin/Evernote/evernoteconnection.cpp (+190/-0)
src/plugin/Evernote/evernoteconnection.h (+101/-0)
src/plugin/Evernote/evernoteplugin.cpp (+14/-2)
src/plugin/Evernote/jobs/createnotejob.cpp (+2/-2)
src/plugin/Evernote/jobs/createnotejob.h (+4/-5)
src/plugin/Evernote/jobs/deletenotejob.cpp (+2/-2)
src/plugin/Evernote/jobs/deletenotejob.h (+4/-4)
src/plugin/Evernote/jobs/evernotejob.cpp (+12/-19)
src/plugin/Evernote/jobs/evernotejob.h (+3/-8)
src/plugin/Evernote/jobs/fetchnotebooksjob.cpp (+2/-2)
src/plugin/Evernote/jobs/fetchnotebooksjob.h (+4/-4)
src/plugin/Evernote/jobs/fetchnotejob.cpp (+2/-2)
src/plugin/Evernote/jobs/fetchnotejob.h (+4/-4)
src/plugin/Evernote/jobs/fetchnotesjob.cpp (+4/-2)
src/plugin/Evernote/jobs/fetchnotesjob.h (+4/-4)
src/plugin/Evernote/jobs/fetchusernamejob.cpp (+38/-0)
src/plugin/Evernote/jobs/fetchusernamejob.h (+43/-0)
src/plugin/Evernote/jobs/notesstorejob.cpp (+39/-0)
src/plugin/Evernote/jobs/notesstorejob.h (+44/-0)
src/plugin/Evernote/jobs/savenotejob.cpp (+2/-2)
src/plugin/Evernote/jobs/savenotejob.h (+4/-4)
src/plugin/Evernote/jobs/userstorejob.cpp (+39/-0)
src/plugin/Evernote/jobs/userstorejob.h (+46/-0)
src/plugin/Evernote/notesstore.cpp (+24/-131)
src/plugin/Evernote/notesstore.h (+13/-44)
src/plugin/Evernote/userstore.cpp (+38/-95)
src/plugin/Evernote/userstore.h (+19/-5)
tags: | added: needs-design |
Changed in reminders-app: | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in reminders-app: | |
assignee: | nobody → Michael Zanetti (mzanetti) |
Changed in account-plugin-evernote: | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in reminders-app: | |
status: | Triaged → In Progress |
Changed in account-plugin-evernote: | |
assignee: | nobody → Michael Zanetti (mzanetti) |
status: | Triaged → In Progress |
Changed in reminders-app: | |
milestone: | none → 0.4 |
status: | Fix Committed → Fix Released |
summary: |
- Empty account name shown on initial screen + [reminder app] Empty account name shown on initial screen |
Changed in account-plugin-evernote: | |
status: | In Progress → Fix Released |
Fix committed into lp:reminders-app at revision 16, scheduled for release in reminders-app, milestone Unknown